Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Query parameter to membership endpoints #526

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

alexdunnjpl
Copy link
Contributor

@alexdunnjpl alexdunnjpl commented Aug 8, 2024

🗒️ Summary

Applies existing querystring filtering to membership endpoints

⚙️ Test Data and/or Report

Manual test pending

♻️ Related Issues

fixes #298
fixes #491
fixes #492
fixes #490

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, that works also. I will create a PR with the updated integration tests for that PR.

@tloubrieu-jpl
Copy link
Member

@alexdunnjpl is that ok to merge ? I would like to validate that the full test suite works successfully.

@tloubrieu-jpl tloubrieu-jpl merged commit d88c0aa into develop Aug 15, 2024
1 check failed
@tloubrieu-jpl tloubrieu-jpl deleted the membership-querystring-implementation branch August 15, 2024 14:53
tloubrieu-jpl added a commit that referenced this pull request Sep 3, 2024
…h Serverless (#531)

* implement RegistrySearchRequestBuilder.applyMultipleProductsDefaults()

* switch /products and membership endpoints to use applyMultipleProductsDefaults()

* rename RegistrySearchRequestBuilder.onlyLatest() to noSupersededProducts()
the semantics of the new name are clearer and cannot lead to confusion about its behaviour

* fix terraform deployment on MCP dev

* add ssm parameter to share the load balancer domain with other components

* rename noSupersededProduct -> excludeSupersededProducts

* update application.properties for latest code

* make operator, NOT, LIKE, AND, OR antlr tokens case-insensitive

* add Query parameter to membership endpoints (#526)

* Handle Accept header with multiple values (#529)

* properly manage Accept header with multiple options

* move MVC function in appropriate class, add unit tests

---------

Co-authored-by: thomas loubrieu <thomas.loubrieu@jpl.nasa.gov>

* implement PdsProperty

* apply propertiesList response schema to '*' content-type

* implement /properties endpoint

* add warning on /docs end-point which does not work yet

---------

Co-authored-by: edunn <alexander.e.dunn@jpl.nasa.gov>
Co-authored-by: thomas loubrieu <thomas.loubrieu@jpl.nasa.gov>
Co-authored-by: Jordan Padams <33492486+jordanpadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment