Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protection against log spoofing #41

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

Resolve https://github.com/NASA-PDS/registry-common/security/code-scanning/37

⚙️ Test Data and/or Report

Mk.1 Eyeball

♻️ Related Issues

fixes #40

Sorry for the big ball of lint. Relevant change is at https://github.com/NASA-PDS/registry-common/compare/code-scanning-alert-37?expand=1#diff-44a3fe7c92e6be4e43f1bd99836e8af4331ce231e3d2bfda2a9f7f26a63a1e29L383

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Now we have to worry about log injection! 😔

@tloubrieu-jpl tloubrieu-jpl merged commit b9e9528 into main Oct 23, 2023
2 checks passed
@tloubrieu-jpl tloubrieu-jpl deleted the code-scanning-alert-37 branch October 23, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alerts
3 participants