CCPP Framework Meeting Minutes 2024 07 18

Agenda

Attendees: Mike Kavulich,

None

Option 1: One approval each from NCAR (SIMA) and DTC (UFS)
- Option 1b: Also Navy (NEPTUNE)?
Option 2: Same as 1, but person who opened PR can "self-approve"
Option 3: Two/Three/## approvals total

Option 1: Merge by PR author once approvals are met and all tests are passing
Option 2: Merge by code manager once approvals are met and all tests are passing
Option 3: Either 1 or 2

CCPP Framework

Equivalent units (Dustin)
- Dustin hasn’t gotten around to it
- Needs some prebuild changes
Use absolute paths for dependencies
- Capgen context: CCPP datatable XML allows host model to see what the CCPP requires (dependencies, variables, etc) so the host can parse it
- waiting on approval from Dom

Discussion

Rules for merging into “develop”
- Approval:
  - Settled on option 1b (at least one approval from each model - SIMA, UFS, NEPTUNE (no self-approvals)
    - Cheryl: will need to get Dom’s feedback on whether his approval is always necessary (he’s the only one from Neptune)
    - Grant: maybe Dom only approves when we merge to main?
Merging:
- Different rules for “main”!
- settled on option 3 - either PR author or code manager hits "merge"
  - Michael W - person who clicks merge button has “author” field in commit?
    - Michael K - has seen in short-range weather app that author is person who opened PR (maybe a configurable setting?)
- Default to “squash and merge” when merge commit
- Michael K - add timeline; after a week maybe code manager merges, so author can control what goes in
  - Cheryl - someone who wants to add to a PR that has been approved should move it to draft
- Michael W - should consider, in the future, that many code authors may not have access to pressing the merge button

CCPP Framework wiki