Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some examples in music-box-interactive-api do not run correctly under Musica 0.7.3 #187

Closed
carl-drews opened this issue Aug 13, 2024 · 3 comments

Comments

@carl-drews
Copy link
Collaborator

Some of the JSON configurations are not compatible with the python music-box and musica 0.7.3. For example, I made these corrections while testing:

--- a/interactive/api/static/examples/FLOW_TUBE/camp_data/config.json
+++ b/interactive/api/static/examples/FLOW_TUBE/camp_data/config.json
@@ -1,7 +1,7 @@
{
"camp-files" : [

  • "camp_data/species.json",
  • "camp_data/reactions.json",
  •   "camp_data/tolerance.json"
    
  • "species.json",
  • "reactions.json",
  •   "tolerance.json"
    
    ]
    }

--- a/interactive/api/static/examples/FLOW_TUBE/camp_data/species.json
+++ b/interactive/api/static/examples/FLOW_TUBE/camp_data/species.json
@@ -3,8 +3,7 @@
{
"name": "M",
"type": "CHEM_SPEC",

  •  "tracer type": "CONSTANT",
    
  •  "description": "Third-body molecule. This is any molecule present in the system."
    
  •  "tracer type": "CONSTANT"
    
    },

That is not an exhaustive list. Do we desire to make these corrections now or later?

@carl-drews
Copy link
Collaborator Author

See also:
Validate all configuration in MusicBox curriculum examples #161
#161

@K20shores K20shores added this to the MusicBox IGAC Demo milestone Aug 13, 2024
@K20shores
Copy link
Collaborator

Music box interactive (specifically the API server) generates (and stores) configurations with the path camp_data/species.json. We need to decide if we need to make music-box conform to the api server, or the other way around. @mattldawson what do you think?

@K20shores
Copy link
Collaborator

All examples are now passing on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants