-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Functional docker container build and run with test data
- Loading branch information
Showing
2 changed files
with
17 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
738fadd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile
a) line 6: install GRAF v2.4 here(?)
b) line 18: Docker is a container that is a ~venv so no need to install new venv into this container.
c) line 25: tells Poetry to use an existing venv instead of create a new one.
d) line 29: this is related to Sphinx documentation build(?)
e) line 30: pytest is for unittesting; not needed outside of the DEV environment; sma eof rpre-commit.
f) line 37: also learn how to access the container into its command line interface, where you could execute explicit commands against the running container
Readme.md
a) line 33: because the codebase will not update frequently, we would consider a container registry for this artifact, where the pipeline fetches it, to run it when needed.