Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 237, ensure ancestry plot only uses project QC, standardizing plots in QC report #273

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cgr_gwas_qc/workflow/scripts/sample_concordance.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def _discordant_logic(sr: pd.Series) -> bool:
]
):
# No metrics so ignore
# Issue 210: If someone is an expected replicates but has no PLINK, GRAF, or KING then these should be flagged as an discordant replicate (True). Before was returning False
# Issue 210: If someone is an expected replicates but has no PLINK, GRAF, or KING then these should be flagged as an discordant replicate (True). Before was returning False
return True

if pd.notna(sr.PLINK_is_ge_concordance):
Expand Down
1 change: 0 additions & 1 deletion src/cgr_gwas_qc/workflow/scripts/sample_qc_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ def _read_intensity(file_name: Optional[Path], Sample_IDs: pd.Index) -> pd.Serie
.IdatIntensity
)


# TO-ADD: Add a parsing/summary function that returns a Series or DataFrame indexed by Sample_ID


Expand Down
Loading