-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add a generic slurm cluster submit option #283
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7310e8 - Browse repository at this point
Copy the full SHA b7310e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 626bb21 - Browse repository at this point
Copy the full SHA 626bb21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b766af - Browse repository at this point
Copy the full SHA 5b766afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 305cd98 - Browse repository at this point
Copy the full SHA 305cd98View commit details -
Fix Slurm time format for workflows > 24 hours (timedelta)
- Incorrect `timedelta` handling caused Slurm job submission failures for workflows exceeding 24 hours. Python's `timedelta` format (e.g., "1 day, 1:00:00") was incompatible with Slurm. - Introduced `formatted_time` to convert `timedelta` objects to Slurm's required format (https://slurm.schedmd.com/sbatch.html#OPT_time). - This fix resolves errors caused by the incompatible time format in Slurm job submissions. - Applies the same time format fix for Slurm compatibility as commit af39a8d
Configuration menu - View commit details
-
Copy full SHA for 8d267d4 - Browse repository at this point
Copy the full SHA 8d267d4View commit details -
Capture name of slurm partition from config
Users specify the name of the Slurm parition (queue) within the config.yml file in the directory they submit from. The queue name provided will be the slurm parition that all non-local jobs are submitted to.
Configuration menu - View commit details
-
Copy full SHA for 16e8bf4 - Browse repository at this point
Copy the full SHA 16e8bf4View commit details -
Require slurm_partition key for
--slurm
submit- Requires users of `--slurm` to specify the slurm partition in their config.yml file. - Removed the option to specify the slurm partition via the `--queue` when directly submitting with `--slurm`. - Renamed `--slurm-generic` flag to the simpler `--slurm`.
Configuration menu - View commit details
-
Copy full SHA for 5b82c59 - Browse repository at this point
Copy the full SHA 5b82c59View commit details -
Improve Error Message for Missing
slurm_partition
This commit improves the error message displayed when a user runs the `--slurm` option without specifying the required `slurm_partition` key-value pair in their `config.yml` file. The changes include: * Clearer error message highlighting the missing key-value pair and its purpose. * Color-coded output (if terminal supports) for better visual distinction between error and solution. These improvements make it easier for users to understand the error and take corrective action.
Configuration menu - View commit details
-
Copy full SHA for 518885e - Browse repository at this point
Copy the full SHA 518885eView commit details -
Add --slurm-partition option for
cgr config
Users can now specify the desired Slurm partition in their config.yml when building with `cgr config --slurm-partition <partition_name>`. This partition is used for jobs submitted with `cgr submit --slurm`.
Configuration menu - View commit details
-
Copy full SHA for 3cb7ae2 - Browse repository at this point
Copy the full SHA 3cb7ae2View commit details -
docs: update conf.py with author information
Add RTI International contributors to the author list.
Configuration menu - View commit details
-
Copy full SHA for 5d1e546 - Browse repository at this point
Copy the full SHA 5d1e546View commit details -
docs: include documentation about new
--slurm
option- Add documentation about the `--slurm-partition` option for the `cgr config` command. - Add documentation about the `--slurm` option for the `cgr submit` command. - Fix typo in a warning message about sample sheet requirement in `cgr_gwas_qc/cli/config.py` `docs/getting_started/running_pipeline.rst` file. - Fix typo in a message to Biowulf users in the `docs/getting_started/running_pipeline.rst` file.
Configuration menu - View commit details
-
Copy full SHA for 7c81c14 - Browse repository at this point
Copy the full SHA 7c81c14View commit details -
docs: update software params to align with current defaults
In commit bd74c72 we increased the `ibd_pi_hat_min` from 0.05 to 0.12 to focus on closer relatives. This commit aligns our documentation with that new default.
Configuration menu - View commit details
-
Copy full SHA for 11b8d3c - Browse repository at this point
Copy the full SHA 11b8d3cView commit details -
Update tests to include the generic slurm submission feature
We have the option to submit to a generic slurm cluster profile now with `cgr submit --slurm`, so this commit updates the tests to incorporate this new feature.
Configuration menu - View commit details
-
Copy full SHA for 626c62d - Browse repository at this point
Copy the full SHA 626c62dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3beffc6 - Browse repository at this point
Copy the full SHA 3beffc6View commit details