Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make open content scale #152

Merged
merged 5 commits into from
May 24, 2024
Merged

feat: make open content scale #152

merged 5 commits into from
May 24, 2024

Conversation

henriettemoe
Copy link

@henriettemoe henriettemoe commented May 6, 2024 •
edited
Loading

  • Renders open content in 3d instead of 2d, so that it scales together with the scene.
  • Fixes bug with drag. Using the anchors to resize open content didn't work - it changed the camera position and the user was unable to move the scene view, zoom or interaction with certain elements.
  • Corrects the boolean horizontal drag value that's sent to onAnchorDragMouseDown.

@henriettemoe henriettemoe marked this pull request as ready for review May 6, 2024 11:04
otacke
otacke approved these changes May 24, 2024
View reviewed changes
Copy link

@otacke otacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@otacke otacke merged commit b61a50f into master May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otacke otacke otacke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henriettemoe @otacke