Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skybox settings, sound settings and room behavior enums values #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yanis002
Copy link
Contributor

@Yanis002 Yanis002 commented Dec 21, 2024

this adds support for the different values of skybox settings, sound settings and room behavior commands, builds OK for both games (note: on OoT the SkyboxConfig enum doesn't exist but I decided to add the values in the xml data instead, this way whenever this is documented ZAPD won't need an extra update there)

I'm not sure if a ZAPD update is planned on both repos so I was thinking of opening PRs to add the new enums in the xml, though let me know if it's fine to make the update in code too


oot: https://github.com/Yanis002/oot/tree/more_enums
mm: https://github.com/Yanis002/mm/tree/more_enums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant