-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DW-3359] New workflows for daylight saving checking #2500
base: master
Are you sure you want to change the base?
Conversation
Test Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments.
Also, everything except line 12 of .github/workflows/deploy-to-production_daylight.yml looks to be identical to .github/workflows/deploy-to-production.yml please refactor to make this DRY.
- cron: "0 0 1 4,11 *" | ||
|
||
# Allows you to run this workflow manually from the Actions tab if needed in emergencies | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing a command name.
|
||
on: | ||
schedule: | ||
- cron: "0 0 1 4,11 *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please annotate what time, month etc., this CRON job runs.
- name: IT IS NOT DAYLIGHT SAVING | ||
if: ${{ env.BST_ENV_VAR == env.UTC_ENV_VAR }} | ||
run: | | ||
curl -L -X PUT -H "Accept: application/vnd.github+json" -H 'Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/NHS-digital-website/hippo/actions/workflows/#TODO/disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this line say todo?
No description provided.