Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Academic page tabs and exams timeline #1379

Merged
merged 11 commits into from
Jan 2, 2025
Merged

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Nov 3, 2024

Closes #1377

Final result:
This may need little adjustments in the future to add more space, but good for now

Roadmap

@thePeras thePeras force-pushed the redesign/exams_page branch from 9f66705 to f8f3b3b Compare November 4, 2024 17:21
@thePeras thePeras force-pushed the redesign/exams_page branch from f8f3b3b to d06f88e Compare November 4, 2024 17:29
@thePeras thePeras changed the base branch from develop to ui/redesign November 4, 2024 21:01
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 6.03448% with 109 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (92e33f6) to head (3e4468a).
Report is 13 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1379   +/-   ##
===========================================
- Coverage           12%     12%   -0%     
===========================================
  Files              265     266    +1     
  Lines             7209    7277   +68     
===========================================
+ Hits               806     810    +4     
- Misses            6403    6467   +64     

@thePeras thePeras marked this pull request as ready for review November 11, 2024 14:23
@thePeras thePeras requested a review from a team November 11, 2024 14:24
@thePeras thePeras mentioned this pull request Nov 11, 2024
7 tasks
@limwa
Copy link
Member

limwa commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button).
Maybe we could put it above the title or next to "MT"?

@thePeras
Copy link
Member Author

thePeras commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). Maybe we could put it above the title or next to "MT"?

The ux would be compromised with your suggestions. We need a button to allow fat fingers ^.^

@DGoiana
Copy link
Collaborator

DGoiana commented Nov 12, 2024

Do not forget to add the timeline.

@limwa
Copy link
Member

limwa commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). Maybe we could put it above the title or next to "MT"?

The ux would be compromised with your suggestions. We need a button to allow fat fingers ^.^

That ultimately depends on how big the "hitbox" is. You can have a small-medium icon with a big hitbox. Doesn't compromise on UX and is more visually pleasing. Either way, if this doesn't work, imo we should try to come up with a solution that does.

@thePeras thePeras force-pushed the redesign/exams_page branch from 3e34a05 to 8f33af3 Compare December 2, 2024 18:56
@thePeras thePeras requested review from vitormpp and a team December 2, 2024 19:20
@thePeras thePeras requested a review from a team December 23, 2024 19:45
@thePeras thePeras requested a review from DGoiana December 27, 2024 16:28
@Adriano-7
Copy link
Member

Adriano-7 commented Dec 28, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). Maybe we could put it above the title or next to "MT"?

I agree, never really liked the eye , maybe in the future we could move that functionality to a popup like this were we could also have a text description of the action.

Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DGoiana DGoiana mentioned this pull request Jan 2, 2025
7 tasks
@thePeras thePeras merged commit d5f1364 into ui/redesign Jan 2, 2025
6 checks passed
@thePeras thePeras deleted the redesign/exams_page branch January 2, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement exams' page
5 participants