-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Academic page tabs and exams timeline #1379
Conversation
9f66705
to
f8f3b3b
Compare
f8f3b3b
to
d06f88e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1379 +/- ##
===========================================
- Coverage 12% 12% -0%
===========================================
Files 265 266 +1
Lines 7209 7277 +68
===========================================
+ Hits 806 810 +4
- Misses 6403 6467 +64 |
Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). |
The ux would be compromised with your suggestions. We need a button to allow fat fingers ^.^ |
Do not forget to add the timeline. |
That ultimately depends on how big the "hitbox" is. You can have a small-medium icon with a big hitbox. Doesn't compromise on UX and is more visually pleasing. Either way, if this doesn't work, imo we should try to come up with a solution that does. |
3e34a05
to
8f33af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #1377
Final result:
This may need little adjustments in the future to add more space, but good for now
Roadmap