Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no exams in mobility #1402

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: no exams in mobility #1402

wants to merge 2 commits into from

Conversation

limwa
Copy link
Member

@limwa limwa commented Nov 30, 2024

This PR makes it so uni doesn't try to fetch exams for students with the mobility course or other courses with a null id.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (cb285d9) to head (4d0205b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1402   +/-   ##
=======================================
- Coverage       12%     12%   -0%     
=======================================
  Files          266     266           
  Lines         7239    7240    +1     
=======================================
  Hits           806     806           
- Misses        6433    6434    +1     

@limwa
Copy link
Member Author

limwa commented Nov 30, 2024

I can't test this because I don't have a mobility account.
Even then, it's likely that it might not fix the issue.

@thePeras
Copy link
Member

I can't test this because I don't have a mobility account. Even then, it's likely that it might not fix the issue.

I think the issue is more complicated than this. Did you check the student account I leave at #uni-reports?

@limwa
Copy link
Member Author

limwa commented Nov 30, 2024

I can't test this because I don't have a mobility account. Even then, it's likely that it might not fix the issue.

I think the issue is more complicated than this. Did you check the student account I leave at #uni-reports?

Nop, I'll check it out now

@limwa limwa marked this pull request as draft November 30, 2024 21:46
@thePeras
Copy link
Member

thePeras commented Dec 4, 2024

The solution I propose:
If mobility course is identified, get exams method maps every enrollment and gets is exams by using the same method of ge course exams because the html page is exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants