New ui bug-report-page #1417
Open
New ui bug-report-page #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePeras
requested changes
Dec 19, 2024
Comment on lines
+90
to
+91
| bugReportIntro(context), | ||
| dropdownBugSelectWidget(context), |
There was a problem hiding this comment.
Can we put the code direct here? Please
Comment on lines
+164
to
+166
| consentBox(context), | ||
|
|
||
| submitButton(context), |
There was a problem hiding this comment.
Again, these are simple widget that don't need helper methods, just put the code right away
| ), | ||
| enabledBorder: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(8.0), | ||
| borderSide: const BorderSide(color: Color.fromRGBO(102, 9, 16, 1)), |
There was a problem hiding this comment.
hard coded values are not recommended. Get them form theme
Comment on lines
+93
to
+102
| /// `Leave feedback | ||
| String get leave_feedback { | ||
| return Intl.message( | ||
| 'Leave feedback', | ||
| name: 'leave feedback', | ||
| desc: '', | ||
| args: [], | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Did you put this directly in this file?
Comment on lines
+34
to
+43
| final Map<int, (String, String)> bugDescriptions = { | ||
| 0: const ('Detalhe visual', 'Visual detail'), | ||
| 1: const ('Erro', 'Error'), | ||
| 2: const ('Sugestão de funcionalidade', 'Suggestion'), | ||
| 3: const ( | ||
| 'Comportamento inesperado', | ||
| 'Unexpected behaviour', | ||
| ), | ||
| 4: ('Outro', 'Other'), | ||
| }; |
There was a problem hiding this comment.
This could be an opportunity to just list the items keys and deal with the translations at the l10n files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1350
Created a new file called 'form2.dart' that it's a copy of 'form.dart' and in that new file I did some ui changes.
I also created a new string in 'I10n.dart' that includes the title of the page.
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change