Updating hall of fame when updating projects

NIAEFEUP · Aug 7, 2023 · c6f6983 · c6f6983
1 parent 511e498
commit c6f6983
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 1 deletion.
diff --git a/src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/ProjectService.kt b/src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/ProjectService.kt
@@ -39,7 +39,15 @@ class ProjectService(
 
     fun updateProjectById(id: Long, dto: ProjectDto): Project {
         val project = getProjectById(id)
-        return updateActivityById(project, dto, IMAGE_FOLDER)
+        val newProject = updateActivityById(project, dto, IMAGE_FOLDER)
+        newProject.apply {
+            hallOfFame.clear()
+            dto.hallOfFameIds?.forEach {
+                val account = accountService.getAccountById(it)
+                hallOfFame.add(account)
+            }
+        }
+        return repository.save(newProject)
     }
 
     fun deleteProjectById(id: Long) {

diff --git a/src/test/kotlin/pt/up/fe/ni/website/backend/controller/ProjectControllerTest.kt b/src/test/kotlin/pt/up/fe/ni/website/backend/controller/ProjectControllerTest.kt
@@ -612,6 +612,7 @@ internal class ProjectControllerTest @Autowired constructor(
         private val newTitle = "New Title"
         private val newDescription = "New description of the project"
         private val newTeamMembers = mutableListOf<Long>()
+        private val newHallOfFame = mutableListOf<Long>()
         private val newIsArchived = true
         private val newSlug = "new-slug"
         private val newSlogan = "new slogan"
@@ -629,6 +630,7 @@ internal class ProjectControllerTest @Autowired constructor(
                 "title" to newTitle,
                 "description" to newDescription,
                 "teamMembersIds" to newTeamMembers,
+                "hallOfFameIds" to newHallOfFame,
                 "isArchived" to newIsArchived,
                 "slug" to newSlug,
                 "slogan" to newSlogan,
@@ -665,6 +667,7 @@ internal class ProjectControllerTest @Autowired constructor(
                     jsonPath("$.title").value(newTitle),
                     jsonPath("$.description").value(newDescription),
                     jsonPath("$.teamMembers.length()").value(newTeamMembers.size),
+                    jsonPath("$.hallOfFame.length()").value(newHallOfFame.size),
                     jsonPath("$.isArchived").value(newIsArchived),
                     jsonPath("$.slug").value(newSlug),
                     jsonPath("$.slogan").value(newSlogan),
@@ -695,6 +698,60 @@ internal class ProjectControllerTest @Autowired constructor(
             assertEquals(testProject.image, updatedProject.image)
         }
 
+        @Test
+        fun `should update the project with different hall of fame members`() {
+            projectPart["hallOfFameIds"] = listOf(testAccount.id!!)
+
+            mockMvc.multipartBuilder("/projects/${testProject.id}")
+                .asPutMethod()
+                .addPart("project", objectMapper.writeValueAsString(projectPart))
+                .perform()
+                .andExpectAll(
+                    status().isOk,
+                    content().contentType(MediaType.APPLICATION_JSON),
+                    jsonPath("$.hallOfFame.length()").value(1),
+                    jsonPath("$.hallOfFame[0].id").value(testAccount.id!!),
+                )
+//                .andDocument(
+//                    documentation,
+//                    "Update projects",
+//                    "Update a previously created project, using its ID.",
+//                    urlParameters = parameters,
+//                    documentRequestPayload = true
+//                )
+
+            val updatedProject = repository.findById(testProject.id!!).get()
+            assertEquals(1, updatedProject.hallOfFame.size)
+            assertEquals(testAccount.id, updatedProject.hallOfFame[0].id)
+        }
+
+        @Test
+        fun `should update the project with different team members`() {
+            projectPart["teamMembersIds"] = listOf(testAccount2.id!!)
+
+            mockMvc.multipartBuilder("/projects/${testProject.id}")
+                .asPutMethod()
+                .addPart("project", objectMapper.writeValueAsString(projectPart))
+                .perform()
+                .andExpectAll(
+                    status().isOk,
+                    content().contentType(MediaType.APPLICATION_JSON),
+                    jsonPath("$.teamMembers.length()").value(1),
+                    jsonPath("$.teamMembers[0].id").value(testAccount2.id!!),
+                )
+//                .andDocument(
+//                    documentation,
+//                    "Update projects",
+//                    "Update a previously created project, using its ID.",
+//                    urlParameters = parameters,
+//                    documentRequestPayload = true
+//                )
+
+            val updatedProject = repository.findById(testProject.id!!).get()
+            assertEquals(1, updatedProject.teamMembers.size)
+            assertEquals(testAccount2.id, updatedProject.teamMembers[0].id)
+        }
+
         @Test
         fun `should update the project with the same slug`() {
             projectPart["slug"] = testProject.slug!!