Migrate to sveltekit 2 and update deps #276
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #276 +/- ##
===========================================
- Coverage 100.00% 1.01% -98.99%
===========================================
Files 2 49 +47
Lines 16 1584 +1568
Branches 4 51 +47
===========================================
Hits 16 16
- Misses 0 1521 +1521
- Partials 0 47 +47 ☔ View full report in Codecov by Sentry. |
|
Currently, this PR is missing two things: @LuisDuarte1 is updating the storybook tests CI to run locally but it is running infinitely. The dependencies upgrade part seems to be done already, but it generating some overriding peer dependency warnings regarding vite that we would like to try to get rid of. @jpnsantoss experimented with |
There was a problem hiding this comment.
Nothing to point out, let's just wait for what @MRita443 said
LuisDuarte1
force-pushed
the
fix/updateDeps
branch
from
8279122 to
2fb1530
Compare
|
The CI is now running the storybook web server locally, however, it's not an optimal CI setup, we could cache the playwright dependencies and cache the storybook-static folder in case there aren't any changes. This is not a priority because we have unlimited minutes so I'll open an issue to optimize the CI. |
| @@ -17,55 +17,59 @@ | |||
| "test-vite:watch": "vitest --watch", | |||
| "test-storybook": "test-storybook --browsers firefox", | |||
| "test-storybook:coverage": "npm run test-storybook -- --coverage", | |||
| "lint": "prettier --plugin-search-dir . --check . && eslint .", | |||
| "format": "prettier --plugin-search-dir . --write .", | |||
| "test-storybook:ci": "concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"npx http-server storybook-static --port 6006 --silent\" \"npx wait-on tcp:127.0.0.1:6006 && npm run test-storybook:coverage\"", | |||
There was a problem hiding this comment.
I'm a bit lazy so can you please explain this part? -k -s first -n \"SB,TEST\" -c \"magenta,blue\" I'm curious 🥺
There was a problem hiding this comment.
It's just for styling, it prepends SB and TEST before each concurrent part and also adds some colors to it 😅
It's nice that we have unlimited minutes but it's still a much better dev experience to have the folder cached, it should be a priority imo |
MRita443
force-pushed
the
fix/updateDeps
branch
from
55e295a to
f04f73f
Compare
No description provided.