Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

289 auth login page functionality #296

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Conversation

AvilaAndre
Copy link
Contributor

@AvilaAndre AvilaAndre commented Nov 16, 2024

Closes #289

Performs the request to the backend to login, showing a message if it succeeds or not and redirecting to the landing page if it does.

This pull request also includes changes to the docker compose, due to requiring access to the localhost in a development environment to access the backend.

Screenshots

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@AvilaAndre AvilaAndre linked an issue Nov 16, 2024 that may be closed by this pull request
@AvilaAndre
Copy link
Contributor Author

There are none of the remaining auth methods, there is a logout in the page /profile which validates the auth with the backend, something like that could be used to manage session on the frontend, however, I do not know which way would be more efficient and therefore I haven't started it in this PR.

@MRita443 MRita443 self-requested a review November 20, 2024 16:59
@MRita443
Copy link
Collaborator

@AvilaAndre Check linter pls ;(

@MRita443
Copy link
Collaborator

While you're at it, can you remove version: '3' from docker-compose.yaml? It's deprecated

Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! :)

@MRita443 MRita443 merged commit c06cc9d into develop Nov 27, 2024
5 checks passed
@MRita443 MRita443 deleted the 289-auth-login-page-functionality branch November 27, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth: login page functionality
2 participants