Use domain crate NSEC3 support. #6
Open
+2,061
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
requested review from
partim,
tertsdiepraam,
bal-e,
Philip-NLnetLabs and
a team
and removed request for
partim,
tertsdiepraam,
mozzieongit,
Philip-NLnetLabs and
bal-e
12 tasks
…g is not specified which will be fixed by PR #428.
… an existing 3rd party ldns Docker image.
…t tests don't write to stdout.
… more human readable error message on test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently depends on
domainbranchinitial-nsec3-generation, see NLnetLabs/domain#416.Contains several kinds of tests:
tests/(ignored by default) that compare outputs to those of a host installedldns-nsec3-hashcommand.fuzz/(must be explicitly run usingcargo +nightly fuzz)Pending issues:
The integration test is failing because
dnstexits with code 2 on command line argument parsing failure, whileldns-nsec3-hashexits with code 1. As this is perhaps something that we need to deal with for alldnst xxxvsldns-xxxcommands and as PR Modify Clap usage to better match LDNS #13 showed one way to deal with this, I don't currently attempt to solve it in this PR.Ideally we want to set the default number of iterations to 0 for
dnst nsec3-hashand leave it at 1 for backward compatibility forldns-nsec3-hash. This PR doesn't contain a way to handle that "muliticall" support or have different defaults for different binary names/sym links via which we are invoked. PR Modify Clap usage to better match LDNS #13 showed one way to deal with this but has not been accepted, and PR Implement ldns-update and dnst update #10 also intends to offer a way to deal with this. Once the way forward is clear this PR should be updated to use the chosen approach.This PR also thus doesn't yet test invocation of itself under the name
ldns-nsec3-hash.