Use an Arc to share stub resolver #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This somewhat simplifies usage for call sites. They no longer need to use `&&StubResolver` for some APIs, and a future can be handed off without being tied to the lifetime of the resolver. The documentation already mentioned that the StubResolver was behind an Arc so I did not need to updated it. StubResolver now implements clone, which is cheap since it merely clones the Arc with the inner data. This change is backwards-incompatible, and necessitates a bump in minor for the next unstable release. Fixes: NLnetLabs#175
WhyNotHugo
force-pushed
the
arc-stub-resolver
branch
from
ef4ba58
to
87ffe8b
Compare
|
v2: formatting |
WhyNotHugo
force-pushed
the
arc-stub-resolver
branch
2 times, most recently
from
ea465e3
to
87ffe8b
Compare
|
Thank you for the PR! Would it make sense to offer both, i.e., the current resolver and, say, a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somewhat simplifies usage for call sites. They no longer need to use
&&StubResolverfor some APIs, and a future can be handed off without being tied to the lifetime of the resolver.The documentation already mentioned that the StubResolver was behind an Arc so I did not need to updated it. StubResolver now implements clone, which is cheap since it merely clones the Arc with the inner data.
This change is backwards-incompatible, and necessitates a bump in minor for the next unstable release.
Fixes: #175