-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the docs build! + Remove unsupported options from Sphinx config + Update deps + add rst_prolog #404
Fix the docs build! + Remove unsupported options from Sphinx config + Update deps + add rst_prolog #404
Conversation
Fun fact, it's PR 404 not found. |
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for the patches @melroy89! I pushed minor corrections to |
Right, I don't know how to handle this situation now. I'll let another dev handle it. Still, thank you for the work. @wtoorop, @wcawijngaards, @gthess, care to pitch in here? I'm not against @melroy89 stating his name in |
Sorry if I got that wrong. I'm new here, but I thought the changelog is stated who did the change. Right? I'm confused indeed. |
@k0ekk0ek anyhow I changed it back to jeroen if that is how the changelog works. 😅 |
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
Yes please merge 😁 so the docs is fixed again. |
Great! Thanks for figuring out the |
No problem. The warnings about Do we need to extend: https://nsd.docs.nlnetlabs.nl/en/latest/reference/configure-options.html ? Or introduce another page? |
@k0ekk0ek Problem found!
I was missing the following config in the
conf.py.in
file:Output is now correct:
Updated directly to the latest version of Sphinx (v8).
I also explicitly pinned the version of
sphinx-substitution-extensions
, since it was installing 2022 for some reason (instead of 2024)Extend RELNOTES & ChangeLog
Plus I saw some warnings, so hence this PR to fix those as well:
display_version
, see: Latest released version asserts "unsupported theme option 'display_version' given" Warning readthedocs/sphinx_rtd_theme#1623 (comment)html_theme_path
, this is not required anymore. See: https://sphinx-rtd-theme.readthedocs.io/en/latest/changelog.htmlOriginal build output: