Add Human readable Serializers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative approach would be to provide them as a module for use with Serde’s |
- remove `human_serde` feature - HumanReadableCommunity type with Serializer impl - regular derive(Serialize) on Community - generic communities() and all_communities() on Update
DRiKE
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed my mind, and think that the somewhat special Serializers for HopPath and Community should live in routecore. They can be behind a feature flag, so that people don't have to use them. I am still trying to figure out if I can make it so that users can chose which serialization they use.
This would enable
rototo use the routecore types directly, otherwise I would have to stick to NewTypes for HopPath and Communities. Also I think it's better if Rotonda doesn't have its own Serializer.