Tidy up Cargo.toml #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
density215
approved these changes
Jan 9, 2024
partim
reviewed
Jan 9, 2024
| chrono = { version = "0.4.20", optional = true } | ||
| const-str = { version = "0.5", optional = true, features = ["case"] } | ||
| log = { version = "0.4.4", optional = true } | ||
| octseq = { version = "0.3.1", features = ["bytes"], optional = true } |
There was a problem hiding this comment.
Maybe swap option and features here (and also for tokio), so that optional is always first which, I think, is the more important information here.
There was a problem hiding this comment.
Yes. Did that for the other PR which obsoletes this one.
density215
approved these changes
Jan 9, 2024
|
All of this PR is part of #44, and then some. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Cargo.toml file, and sets the versions of the dependencies to their actual minimums for successful compilation.
Checked via
cargo +nightly update -Z minimal-versions && cargo test --all-features.