Add cargo check+test for minimal-versions in CI #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
reviewed
Jan 9, 2024
.github/workflows/ci.yml
Outdated
| - if: matrix.rust == 'nightly' | ||
| run: | | ||
| cargo +nightly update -Z minimal-versions | ||
| cargo check --all-features --verbose --all-targets |
There was a problem hiding this comment.
Given that this is basically just a Will It Compile test, I suppose adding the --tests (and possibly --examples) options to this cargo check and dropping the cargo test below will be sufficient and save some cycles.
There was a problem hiding this comment.
The separate check is indeed not super useful, though separate build and test is convenient to quickly spot where things go wrong. (Note that this was inspired by the ci.yml in the domain crate, so we might want to have a look at that one as well).
On saving cycles, it might actually make more sense to get rid of the beta/nightly runs.
…t-in-ci' into minimal-version-test-in-ci
density215
approved these changes
Jan 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI job testing whether the minimal versions as specified in Cargo.toml actually compile and pass the unit tests.