-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path attributes builder #48
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d16d5cc - Browse repository at this point
Copy the full SHA d16d5ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3adb585 - Browse repository at this point
Copy the full SHA 3adb585View commit details -
Configuration menu - View commit details
-
Copy full SHA for 125948f - Browse repository at this point
Copy the full SHA 125948fView commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9636412 - Browse repository at this point
Copy the full SHA 9636412View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f082cbe - Browse repository at this point
Copy the full SHA f082cbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d71103e - Browse repository at this point
Copy the full SHA d71103eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43ebbaa - Browse repository at this point
Copy the full SHA 43ebbaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03b009f - Browse repository at this point
Copy the full SHA 03b009fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f025e45 - Browse repository at this point
Copy the full SHA f025e45View commit details -
Configuration menu - View commit details
-
Copy full SHA for c637d37 - Browse repository at this point
Copy the full SHA c637d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 088fa8d - Browse repository at this point
Copy the full SHA 088fa8dView commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 49d6907 - Browse repository at this point
Copy the full SHA 49d6907View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4f2ef4 - Browse repository at this point
Copy the full SHA c4f2ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d8235 - Browse repository at this point
Copy the full SHA 68d8235View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10bb67c - Browse repository at this point
Copy the full SHA 10bb67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b61d10 - Browse repository at this point
Copy the full SHA 0b61d10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2df9a19 - Browse repository at this point
Copy the full SHA 2df9a19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 732a802 - Browse repository at this point
Copy the full SHA 732a802View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14e9f21 - Browse repository at this point
Copy the full SHA 14e9f21View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d77fb9b - Browse repository at this point
Copy the full SHA d77fb9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8884944 - Browse repository at this point
Copy the full SHA 8884944View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ef9caa - Browse repository at this point
Copy the full SHA 2ef9caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b05c9c - Browse repository at this point
Copy the full SHA 4b05c9cView commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 28bd7f7 - Browse repository at this point
Copy the full SHA 28bd7f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for adce9e2 - Browse repository at this point
Copy the full SHA adce9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1de1ac6 - Browse repository at this point
Copy the full SHA 1de1ac6View commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf0b4cf - Browse repository at this point
Copy the full SHA bf0b4cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc915e - Browse repository at this point
Copy the full SHA 9bc915eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 912a530 - Browse repository at this point
Copy the full SHA 912a530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17deeb6 - Browse repository at this point
Copy the full SHA 17deeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74a94fe - Browse repository at this point
Copy the full SHA 74a94feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 422c2dc - Browse repository at this point
Copy the full SHA 422c2dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c565171 - Browse repository at this point
Copy the full SHA c565171View commit details -
Configuration menu - View commit details
-
Copy full SHA for 416814d - Browse repository at this point
Copy the full SHA 416814dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2abf4b - Browse repository at this point
Copy the full SHA f2abf4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e567a7 - Browse repository at this point
Copy the full SHA 5e567a7View commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f96a767 - Browse repository at this point
Copy the full SHA f96a767View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0eb2b - Browse repository at this point
Copy the full SHA 3d0eb2bView commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce8920f - Browse repository at this point
Copy the full SHA ce8920fView commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 84c712a - Browse repository at this point
Copy the full SHA 84c712aView commit details -
Configuration menu - View commit details
-
Copy full SHA for acdbb1e - Browse repository at this point
Copy the full SHA acdbb1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5524cb3 - Browse repository at this point
Copy the full SHA 5524cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1dfac - Browse repository at this point
Copy the full SHA 9d1dfacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8617b49 - Browse repository at this point
Copy the full SHA 8617b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b459f - Browse repository at this point
Copy the full SHA 08b459fView commit details -
Merge remote-tracking branch 'refs/remotes/origin/path-attributes-bui…
…lder' into path-attributes-builder
Configuration menu - View commit details
-
Copy full SHA for 580ef94 - Browse repository at this point
Copy the full SHA 580ef94View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7e6322 - Browse repository at this point
Copy the full SHA c7e6322View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0bf4c5 - Browse repository at this point
Copy the full SHA f0bf4c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d601004 - Browse repository at this point
Copy the full SHA d601004View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7cb212 - Browse repository at this point
Copy the full SHA c7cb212View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f5f85 - Browse repository at this point
Copy the full SHA 98f5f85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 599fd1e - Browse repository at this point
Copy the full SHA 599fd1eView commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb2ea70 - Browse repository at this point
Copy the full SHA cb2ea70View commit details -
Configuration menu - View commit details
-
Copy full SHA for d05afe8 - Browse repository at this point
Copy the full SHA d05afe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18673d5 - Browse repository at this point
Copy the full SHA 18673d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a3e541 - Browse repository at this point
Copy the full SHA 2a3e541View commit details -
Configuration menu - View commit details
-
Copy full SHA for 401b755 - Browse repository at this point
Copy the full SHA 401b755View commit details -
Configuration menu - View commit details
-
Copy full SHA for 655958c - Browse repository at this point
Copy the full SHA 655958cView commit details
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 25ef23d - Browse repository at this point
Copy the full SHA 25ef23dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f74284 - Browse repository at this point
Copy the full SHA 0f74284View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c8fd7 - Browse repository at this point
Copy the full SHA 14c8fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c436c4b - Browse repository at this point
Copy the full SHA c436c4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f3bb29 - Browse repository at this point
Copy the full SHA 7f3bb29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 416ca6c - Browse repository at this point
Copy the full SHA 416ca6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 063eac0 - Browse repository at this point
Copy the full SHA 063eac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b236e14 - Browse repository at this point
Copy the full SHA b236e14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4676217 - Browse repository at this point
Copy the full SHA 4676217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f44f2b - Browse repository at this point
Copy the full SHA 7f44f2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82173c7 - Browse repository at this point
Copy the full SHA 82173c7View commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f3905d - Browse repository at this point
Copy the full SHA 5f3905dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6307b8b - Browse repository at this point
Copy the full SHA 6307b8bView commit details
Commits on Mar 19, 2024
-
Adopt new AfiSafi / Nlri types throughout codebase
This commit adapts the codebase to use the types and traits introduced in this branch. With that, several other concepts required changes, or became deprecated and were removed. The new types/traits include: - trait AfiSafi, describing something that is characterized by a certain AFI+SAFI combination; - trait AfiSafiNlri, an NLRI characterized by a certain AFI+SAFI combination; - enum AfiSafiType, describing all AFI+SAFI combinations we support; - enum Nlri<Octs>, now holding more explicit variants of dedicated types, a la Ipv4UnicastNlri, Ipv6UnicastNlri, etc. For ADD-PATH, dedicated types are generated: Ipv4UnicastAddpathNlri, etc; - On UpdateMessage, `fn typed_announcements()` provides an iterator generic over tpyes implementing AfiSafiParse, thus yielding NLRI of these dedicated types instead of enum variants (which is still available via the `fn announcements()); - UpdateBuilder is now generic over types that implement NlriCompose, making the adding/removing of announcements and withdrawals more straightforward. New generic helper methods include `fn add_announcements_from_pdu`. Other changes: - enum Safi is removed, as an SAFI by itself does not mean anything useful. We keep enum Afi and the new enum AfiSafiType. (The name `AfiSafi` is now used for the new trait); - the UpdateMessage does not hold an entire SessionConfig anymore, but a trimmed down version of the new type PduParseInfo. The SessionConfig is only used in the very first call to `from_octets()` or `parse()`; - MpReachNlri and MpUnreachNlri are not part of the PathAttribute enum anymore, we start treating them differently. Partly because with the new builders being generic, it would mean the enum PathAttribute must carry generic type info, and PaMap as well. All while we most often do not include the MP* attributes in those maps anyway; - the new bgp::nlri modules replaces everyhing that was in bgp::message::nlri Open issues / questions and other remarks: - on UpdateMessage, we had several methods to specifically get unicast announcements. We need to figure out if those are still wanted; - we need to figure out what the Workshop should look like. We can probably get rid of the afisafi_nlri module to a large extent; - the UpdateBuilder now puts all withdrawals and announcements in MP attributes, so nothing goes into the conventional sections in the PDU. Related tests are ignored for now. We need to figure out to what extent we like to support those conventional sections in the builder.
Configuration menu - View commit details
-
Copy full SHA for e84a6af - Browse repository at this point
Copy the full SHA e84a6afView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1f4717 - Browse repository at this point
Copy the full SHA b1f4717View commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b0d704b - Browse repository at this point
Copy the full SHA b0d704bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 431debf - Browse repository at this point
Copy the full SHA 431debfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22758a4 - Browse repository at this point
Copy the full SHA 22758a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4190fa - Browse repository at this point
Copy the full SHA e4190faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15afa31 - Browse repository at this point
Copy the full SHA 15afa31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e0feec - Browse repository at this point
Copy the full SHA 7e0feecView commit details -
Configuration menu - View commit details
-
Copy full SHA for accd569 - Browse repository at this point
Copy the full SHA accd569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7539ee0 - Browse repository at this point
Copy the full SHA 7539ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e37d92 - Browse repository at this point
Copy the full SHA 0e37d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6606341 - Browse repository at this point
Copy the full SHA 6606341View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b541c - Browse repository at this point
Copy the full SHA c8b541cView commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42e90d2 - Browse repository at this point
Copy the full SHA 42e90d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 349923e - Browse repository at this point
Copy the full SHA 349923eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d269b - Browse repository at this point
Copy the full SHA 42d269bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98121c4 - Browse repository at this point
Copy the full SHA 98121c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for af12707 - Browse repository at this point
Copy the full SHA af12707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99f4667 - Browse repository at this point
Copy the full SHA 99f4667View commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ca54e23 - Browse repository at this point
Copy the full SHA ca54e23View commit details -
Configuration menu - View commit details
-
Copy full SHA for a996da4 - Browse repository at this point
Copy the full SHA a996da4View commit details -
Merge remote-tracking branch 'refs/remotes/origin/path-attributes-bui…
…lder' into path-attributes-builder
Configuration menu - View commit details
-
Copy full SHA for 9484e51 - Browse repository at this point
Copy the full SHA 9484e51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b0bbf2 - Browse repository at this point
Copy the full SHA 0b0bbf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8786965 - Browse repository at this point
Copy the full SHA 8786965View commit details -
Make Update::typed_withdrawals consistent with ~announcements, fix bu…
…lk test in UpdateBuilder
Configuration menu - View commit details
-
Copy full SHA for d10f30d - Browse repository at this point
Copy the full SHA d10f30dView commit details -
Configuration menu - View commit details
-
Copy full SHA for de0f76e - Browse repository at this point
Copy the full SHA de0f76eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6b0399 - Browse repository at this point
Copy the full SHA a6b0399View commit details