Remove unused code from the addr module. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRiKE
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Wondering whether we can even get rid of MaxLenPrefix here as well (assuming it's ported to rpki-rs), as I don't think it means anything in BGP outside of RPKI context?
@density215 something smart to say about this?
|
I was thinking about removing it. It will bubble up at some point, though, when you do route origin validation. Maybe that should be in routecore? |
|
Wasn't the plan to move all of the |
|
Yes. Let’s do that next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some code leftover from rpki-rs.