-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding FHMRUVV N3LO splitting functions #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly minor stuff, but
- please check explicitly that you didn't break the LHA benchmarks since they were broken before your last commit and I'm not sure that fixes it (as it was numba complaining)
- we should remember to point them (=FHMRUVV) explicitly to this PR and tell them that they can (and should) start playing on their own
src/ekore/anomalous_dimensions/unpolarized/space_like/__init__.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/__init__.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/__init__.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/__init__.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/ggg.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/ggq.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/ggg.py
Outdated
Show resolved
Hide resolved
src/ekore/anomalous_dimensions/unpolarized/space_like/as4/fhmruvv_approximations/gnsm.py
Outdated
Show resolved
Hide resolved
Do we want to have to have |
is the effort manageable? if it is too much work, I'd say this is surely no priority ... if it is doable, we have to explicitly mention it when writing the mail ... |
It's just adding few if statements, I can do it now. EDIT: done in 517ae10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The moment https://github.com/NNPDF/eko/actions/runs/7489901631/job/20387536993 finished and you checked it, we can merge
Numba failed in https://github.com/NNPDF/eko/actions/runs/7489901631 ... but locally running I should have almost the same python (3.10.13 (me) vs. 3.10.10 (github)), the same numba (0.57.1), and the same numpy (1.24.4); ocard hash is the same (8beae75) (though theory not, but this was already discussed) any ideas? @alecandido maybe? |
It might be due to banana!! |
Okay LHA benchmarks are now working again. 12918f9 |
good catch! let's merge if https://github.com/NNPDF/eko/actions/runs/7500258647/job/20418576973 goes through so we can move on |
This PR is imported from: https://github.com/NNPDF/eko_fhmv_private/pull/1