Review process
"Once a developer/contributor opens a pull request, it will automatically trigger the cobalt_CI workflow to conduct regression testing:
This testing includes three main checks:
- compile/build mom6sis2-cobalt
- run 1D column test
- Check against baseline answers
You can click on Details to see the progress of the workflow.If everything goes well, you should see a green check mark, as shown in the screenshot above. If not, please identify the step at which the crash occurred. If it is due to the baseline check, please highlight the reason why your PR will cause a change in results and provide a new baseline under ocean_BGC/.github/ref/OM4.single_column.COBALT.p4/docker-linux-gnu. The code manager won't assign any reviewers if the PR does not pass AUTO RT check.
So if you find that your PR did not pass the COBALT CI check (with a red cross next to your PR title), you can first click the Details button:
It should take you to the page that shows you which step your PR did not pass. Below is an example where the PR changes the baseline answers and did not pass the baseline check:
In this case, the person who opened the PR should copy the new answers shown on the screen and update the reference (located under ocean_BGC/.github/ref/OM4.single_column.COBALT.p4/docker-linux-gnu/ocean.stats).
Once the PR passes the AUTO RT check, the code manager will assign appropriate reviewers to review the PR. It requires at least one approval before merging the PR back into the main branch.