Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two deprecated utilities #25

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Remove two deprecated utilities #25

merged 2 commits into from
Jan 31, 2024

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Dec 13, 2023 •
edited
Loading

Fixes #24
(can wait till 1/1/2024 to get feedback and comments)

RussTreadon-NOAA
RussTreadon-NOAA reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of global_angupdate being used anywhere. The same comment applies to diag2grads. Let's cross check with @EdwardSafford-NOAA.

ADCollard
ADCollard approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ADCollard ADCollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe either of these utilities are used any more. It is possible that there are still people plotting radiance diag files with GrADS but this particular utility does not appear to support ncdiag files, so it should be OK to remove.

RussTreadon-NOAA
RussTreadon-NOAA approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any developer needs diag2grads or global_angupdate, they can recover either from previous GSI-utils hashes.

Approve.

@aerorahul
Copy link
Contributor Author

@ADCollard @RussTreadon-NOAA
Thank you for your approval.
Please feel free to merge whenever you get a chance.

@RussTreadon-NOAA
Copy link
Contributor

Thanks @aerorahul , you, too, are also free to merge this PR into develop. We don't have a CM for GSI-utils.

@aerorahul aerorahul merged commit dae48c9 into develop Jan 31, 2024
8 checks passed
@aerorahul aerorahul deleted the feature/issue_24 branch January 31, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADCollard ADCollard ADCollard approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove (some) deprecated utilities.
3 participants
@aerorahul @RussTreadon-NOAA @ADCollard