Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wcoss2 modulefile #44

Merged
merged 4 commits into from
May 29, 2024
Merged

Update wcoss2 modulefile #44

merged 4 commits into from
May 29, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR removes /apps/ops/para/libs from gsiutils_wcoss2.intel.lua. Additionally module versions for w3emc, nemsio, and ncdiag are updated to be consistent with GSI gsi_wcoss2.intel.lua.

Resolves #20

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 29, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA , automated tests for gsi-monitor failed. Any idea why gsi-monitor being tested in gsi-utils? GSI-Monitor has its own repository.

FYI, I successfully built feature/wcoss2 on Cactus.

@DavidHuber-NOAA
Copy link
Collaborator

@RussTreadon-NOAA That was a copy-paste error when updating the CI for #19. It is in fact only trying to build gsi-utils but it is mislabeled.

The cause of the failure is that mpif90 is missing. Since this PR only affect Intel compilers on WCOSS2, I'm OK with a GCC failure. I will investigate/fix the CI issues in a separate PR today.

DavidHuber-NOAA
DavidHuber-NOAA approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Would you be able to run this through a cycled test on Cactus?

@RussTreadon-NOAA
Copy link
Contributor Author

Corrected gsi-monitor typo at 6d39a55. Attempt to fix gcc compilation error at 6d39a55 failed.

Installing feature/wcoss2 on Cactus and will run GSI-base DA CI (C96C48_hybatmDA).

@RussTreadon-NOAA
Copy link
Contributor Author

GSI-based (C96C48_hybatmDA) and JEDI-based (C96C48_ufs_hybatmDA) CI run on Cactus by updating sorc/gsi_utils.fd at 6d39a55 in working copy of RussTreadon-NOAA:feature/wcoss2_ufsda. All jobs from both CI tests ran to completion

GSI-based (C96C48_hybatmDA)

russ.treadon@clogin05:/lfs/h2/emc/ptmp/russ.treadon/EXPDIR/prtest_gsi> rocotostat -d prtest_gsi.db -w prtest_gsi.xml -c all -s                
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 29 2024 13:46:37    May 29 2024 14:25:23
202112210000        Done    May 29 2024 13:46:37    May 29 2024 16:52:10
202112210600        Done    May 29 2024 13:46:37    May 29 2024 16:55:14

JEDI-based (C96C48_ufs_hybatmDA)

russ.treadon@clogin05:/lfs/h2/emc/ptmp/russ.treadon/EXPDIR/prtest> rocotostat -d prtest.db -w prtest.xml  -c all -s
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    May 29 2024 13:46:47    May 29 2024 14:20:14
202402240000        Done    May 29 2024 13:46:47    May 29 2024 16:55:11

@RussTreadon-NOAA
Copy link
Contributor Author

GSI-utils PR #45 corrects automated CI. Revert 6d39a55 in feature/wcoss2. Done at 0005fc9.

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA : GSI-based (C96C48_hybatmDA) and JEDI-based (C96C48_ufs_hybatmDA) successfully run on Cactus.

Spot check output from this run with CI tests reported in g-w PR #2620. The PR #2620 CI runs used gsi_utils.fd @ bb03e17. The CI tests reported in this PR use gsi_utils.fd at 6d39a55.

Are there any more checks or tests you would like me to make or run?

@DavidHuber-NOAA
Copy link
Collaborator

Nope, I think this is good to go. Thanks @RussTreadon-NOAA!

@RussTreadon-NOAA
Copy link
Contributor Author

Nope, I think this is good to go. Thanks @RussTreadon-NOAA!

Thank you @DavidHuber-NOAA . Would you re-review and approve? Seems my commits wiped out your earlier approval.

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA : Looks like your approval is there but I still see

Review required
At least 1 approving review is required by reviewers with write access.

Maybe your approval isn't sufficient because you do not have write access to this repo. Is this possible?

@DavidHuber-NOAA
Copy link
Collaborator

@RussTreadon-NOAA I think you are correct. Perhaps @aerorahul can approve.

aerorahul
aerorahul reviewed May 29, 2024
View reviewed changes
modulefiles/gsiutils_wcoss2.intel.lua
Comment on lines -44 to -52

load(pathJoin("prod_util", prod_util_ver))

pushenv("HPC_OPT", "/apps/ops/para/libs")
prepend_path("MODULEPATH", "/apps/ops/para/libs/modulefiles/compiler/intel/19.1.3.304")
prepend_path("MODULEPATH", "/apps/ops/para/libs/modulefiles/mpi/intel/19.1.3.304/cray-mpich/8.1.7")

load("ncio/1.1.2")
load("ncdiag/1.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

aerorahul
aerorahul approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @aerorahul

@RussTreadon-NOAA RussTreadon-NOAA merged commit d940406 into develop May 29, 2024
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request May 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update WCOSS2 Modules
3 participants
@RussTreadon-NOAA @DavidHuber-NOAA @aerorahul