Make GOCART output times a function

Makes GOCART output times a function since it is needed in two places.

ush/forecast_postdet.sh

@@ -697,7 +697,7 @@ GOCART_postdet() {
   echo "SUB ${FUNCNAME[0]}: Linking output data for GOCART"
 
   local vdate
-  for fhr in ${GOCART_OUTPUT_FH}; do
+  for fhr in $(GOCART_output_fh); do
     vdate=$(date --utc -d "${current_cycle:0:8} ${current_cycle:8:2} + ${fhr} hours" +%Y%m%d%H)
 
     # Temporarily delete existing files due to noclobber in GOCART
@@ -711,19 +711,25 @@ GOCART_postdet() {
   done
 }
 
+GOCART_output_fh() {
+  # This has to be called during postdet after FHROT has been set
+  local aero_min
+  local gocart_output_fh
+  aero_min=$(( ${IAU_FHROT:-0} > FHMIN ? IAU_FHROT + FHOUT_AERO : FHMIN + FHOUT_AERO ))
+  gocart_output_fh=$(seq -s ' ' "$(( aero_min ))" "${FHOUT_AERO}" "${FHMAX}")
+
+  echo "${gocart_output_fh}"
+}
+
 GOCART_out() {
   echo "SUB ${FUNCNAME[0]}: Copying output data for GOCART"
 
   # Copy gocart.inst_aod after the forecast is run (and successfull)
   # TODO: this should be linked but there are issues where gocart crashing if it is linked
   local fhr
   local vdate
-  local aero_min
-  local gocart_output_fh
-  aero_min=$(( ${IAU_FHROT:-0} > FHMIN ? IAU_FHROT + FHOUT_AERO : FHMIN + FHOUT_AERO ))
-  gocart_output_fh=$(seq -s ' ' "$(( aero_min ))" "${FHOUT_AERO}" "${FHMAX}")
 
-  for fhr in ${gocart_output_fh}; do
+  for fhr in $(GOCART_output_fh); do
     vdate=$(date --utc -d "${current_cycle:0:8} ${current_cycle:8:2} + ${fhr} hours" +%Y%m%d%H)
     ${NCP} "${DATA}/gocart.inst_aod.${vdate:0:8}_${vdate:8:2}00z.nc4" \
       "${COMOUT_CHEM_HISTORY}/gocart.inst_aod.${vdate:0:8}_${vdate:8:2}00z.nc4"