Make aerosol output frequency variable #2982

WalterKolczynski-NOAA · 2024-10-04T04:58:47Z

Description

The AERO_HISTORY.rc file that controls the GOCART output is turned into a template usint @[ ] syntax to allow for variable output times. A new "parsing" script is created for GOCART that handles parsing the AERO_HISTORY.rc file through atparse. Other manip- ulation of these files is also moved to the new parsing script to be consistent with other components.

A new variable, FHOUT_AERO is introduced to control the output frequency of the GOCART output. This is initially set to 3 to match other components (this is a change from the current value of 6). Since some aerosol fields are also included as part of the atmos output, it may be desirable to meld this back into FHOUT later. However, the atmos output has two frequencies (FHOUT_HF and FHOUT), a feature not supported by other components.

The RUN lists for aero fcst, aero analysis, and waves is simplified to avoid confusion, since there is no need for them to only be set if the components are on.

Resolves #2072

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? NO

How has this been tested?

S2SWA forecast-only on Hercules (manually modifying AERO_FCST_RUN)

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have documented my code, including function, input, and output descriptions
My changes generate no new warnings
New and existing tests pass with my changes
This change is covered by an existing CI test or a new one has been added
I have made corresponding changes to the system documentation if necessary

ush/parsing_namelists_GOCART.sh

parm/config/gfs/config.base

ush/parsing_namelists_GOCART.sh

CoryMartin-NOAA

I didn't test but this looks good to me

parm/config/gfs/config.base

aerorahul

Looks good.
Question:
Not for this PR to address -- how diffferent is the parm/ufs/gocart/AERO_HISTORY.rc file in the global-workflow from the one in ufs-weather-model?

WalterKolczynski-NOAA · 2024-10-04T16:20:52Z

Looks good. Question: Not for this PR to address -- how diffferent is the parm/ufs/gocart/AERO_HISTORY.rc file in the global-workflow from the one in ufs-weather-model?

@aerorahul Looks like they have already templated the one frequency we use, but not the others. A couple other small changes (also whitespace changes not shown):

diff parm/ufs/gocart/AERO_HISTORY.rc sorc/ufs_model.fd/tests/parm/gocart/AERO_HISTORY.rc.IN -b
384c384
<   inst_aod.frequency:  060000,
---
>   inst_aod.frequency:  @[AOD_FRQ],
390a391
>                        'NIEXTTAU'      , 'NI'       , 'AOD_NI',
405,406c406,407
<   tavg_2d_rad.fields:     'CA.bcEXTTAU' , 'CA.bc' ,
< 			  'CA.ocEXTTAU' , 'CA.oc' ,
---
>   tavg_2d_rad.fields:     'CAEXTTAUCA.bc' , 'CA.bc' ,
>                           'CAEXTTAUCA.oc' , 'CA.oc' ,

(This is against our develop, not the changes in this PR.)

emcbot · 2024-10-08T01:07:56Z

Experiment C48_ATM FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C48_ATM_8a18d626

emcbot · 2024-10-08T01:07:56Z

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C48mx500_3DVarAOWCDA_8a18d626

emcbot · 2024-10-08T01:07:58Z

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C48_S2SWA_gefs_8a18d626

emcbot · 2024-10-08T01:07:58Z

Experiment C96_atm3DVar FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C96_atm3DVar_8a18d626

emcbot · 2024-10-08T01:07:59Z

Experiment C48_S2SW FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C48_S2SW_8a18d626

emcbot · 2024-10-08T01:08:00Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_8a18d626

emcbot · 2024-10-08T01:08:00Z

Experiment C96C48_hybatmDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C96C48_hybatmDA_8a18d626

emcbot · 2024-10-08T01:08:01Z

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 2 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_8a18d626

Moves computation of GOCART output times to postdet, since FHROT is not computed until then.

emcbot · 2024-11-14T08:36:04Z

Build FAILED on Hercules in Build# 3 with error logs:

/work2/noaa/global/CI/HERCULES/2982/gefs/sorc/logs/build_upp.log

Follow link here to view the contents of the above file(s): (link)

Makes GOCART output times a function since it is needed in two places.

The defulats file for GEFS was missing an entry for aero to ensure @field@ get parsed at expt setup time. This was added to gfs as part of NOAA-EMC#3053, but gefs was missed.

emcbot · 2024-11-14T21:31:27Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 with error logs:

/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_d953c49c/logs/2021122018/gdas_fcst_seg0.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-11-14T21:31:33Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 in
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_d953c49c

emcbot · 2024-11-14T23:09:03Z

CI Failed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI/2982


Experiment C96_S2SWA_gefs_replay_ics_d953c49c Completed 1 Cycles: *SUCCESS* at Thu Nov 14 21:06:44 UTC 2024
Experiment C48mx500_3DVarAOWCDA_d953c49c Completed 2 Cycles: *SUCCESS* at Thu Nov 14 21:24:56 UTC 2024
Experiment C48_ATM_d953c49c Completed 2 Cycles: *SUCCESS* at Thu Nov 14 21:24:56 UTC 2024
Experiment C96C48_hybatmaerosnowDA_d953c49c Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Thu Nov 14 21:31:11 UTC 2024
Experiment C96C48_hybatmaerosnowDA_d953c49c Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/2982/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_d953c49c/logs/2021122018/gdas_fcst_seg0.log
Experiment C48_S2SWA_gefs_d953c49c Completed 1 Cycles: *SUCCESS* at Thu Nov 14 22:38:52 UTC 2024
Experiment C96_atm3DVar_d953c49c Completed 3 Cycles: *SUCCESS* at Thu Nov 14 22:50:13 UTC 2024
Experiment C96C48_hybatmDA_d953c49c Completed 3 Cycles: *SUCCESS* at Thu Nov 14 22:50:33 UTC 2024
Experiment C48_S2SW_d953c49c Completed 2 Cycles: *SUCCESS* at Thu Nov 14 23:08:33 UTC 2024
Experiment C96C48_ufs_hybatmDA_d953c49c Completed 3 Cycles: *SUCCESS* at Thu Nov 14 23:08:48 UTC 2024

WalterKolczynski-NOAA requested review from CoryMartin-NOAA, aerorahul and DavidHuber-NOAA October 4, 2024 04:58

github-advanced-security bot found potential problems Oct 4, 2024

View reviewed changes

ush/parsing_namelists_GOCART.sh Fixed Show fixed Hide fixed

DavidHuber-NOAA previously approved these changes Oct 4, 2024

View reviewed changes

parm/config/gfs/config.base Show resolved Hide resolved

DavidHuber-NOAA reviewed Oct 4, 2024

View reviewed changes

ush/parsing_namelists_GOCART.sh Show resolved Hide resolved

CoryMartin-NOAA previously approved these changes Oct 4, 2024

View reviewed changes

parm/config/gfs/config.base Show resolved Hide resolved

aerorahul previously approved these changes Oct 4, 2024

View reviewed changes

WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 7, 2024

emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Oct 7, 2024

TerrenceMcGuinness-NOAA removed the CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera label Oct 7, 2024

WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 7, 2024

emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Oct 8, 2024

WalterKolczynski-NOAA added 2 commits November 14, 2024 02:07

Fix GOCART output times

50a15d3

Moves computation of GOCART output times to postdet, since FHROT is not computed until then.

Merge branch 'develop' into feature/gocart_variable_fh

d8d8412

WalterKolczynski-NOAA force-pushed the feature/gocart_variable_fh branch from 914c8a4 to d8d8412 Compare November 14, 2024 08:23

WalterKolczynski-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Nov 14, 2024

emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 14, 2024

WalterKolczynski-NOAA removed the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Nov 14, 2024

Make GOCART output times a function

13ec408

Makes GOCART output times a function since it is needed in two places.

WalterKolczynski-NOAA removed the CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully label Nov 14, 2024

Add mixing defaults entry for aero in GEFS

d953c49

The defulats file for GEFS was missing an entry for aero to ensure @field@ get parsed at expt setup time. This was added to gfs as part of NOAA-EMC#3053, but gefs was missed.

WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 14, 2024

emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 14, 2024

emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make aerosol output frequency variable #2982

Make aerosol output frequency variable #2982

WalterKolczynski-NOAA commented Oct 4, 2024 •

edited

Loading

CoryMartin-NOAA left a comment

aerorahul left a comment

WalterKolczynski-NOAA commented Oct 4, 2024 •

edited

Loading

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

Make aerosol output frequency variable #2982

Are you sure you want to change the base?

Make aerosol output frequency variable #2982

Conversation

WalterKolczynski-NOAA commented Oct 4, 2024 • edited Loading

Description

Type of change

Change characteristics

How has this been tested?

Checklist

CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

aerorahul left a comment

Choose a reason for hiding this comment

WalterKolczynski-NOAA commented Oct 4, 2024 • edited Loading

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Oct 8, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

emcbot commented Nov 14, 2024

WalterKolczynski-NOAA commented Oct 4, 2024 •

edited

Loading

WalterKolczynski-NOAA commented Oct 4, 2024 •

edited

Loading