Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JGDAS ENKF POST job #3090

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Update JGDAS ENKF POST job #3090

merged 4 commits into from
Nov 15, 2024

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf post job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@mingshichen-noaa mingshichen-noaa added the CI/CD Issue related to CI/CD label Nov 12, 2024
DavidHuber-NOAA
DavidHuber-NOAA requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The J-Job needs to be here, too.

@mingshichen-noaa mingshichen-noaa self-assigned this Nov 12, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Nov 12, 2024 •
edited
Loading

The J-Job needs to be here, too.

This J-Job defines no COM variables

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. Thanks @mingshichen-noaa @WalterKolczynski-NOAA.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mingshichen-noaa !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Nov 12, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 12, 2024
@emcbot
Copy link

emcbot commented Nov 12, 2024

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3090


Experiment C96_S2SWA_gefs_replay_ics_b27c6cf6 Completed 1 Cycles: *SUCCESS* at Tue Nov 12 14:00:05 CST 2024
Experiment C48_ATM_b27c6cf6 Completed 2 Cycles: *SUCCESS* at Tue Nov 12 14:18:10 CST 2024
Experiment C96_atm3DVar_b27c6cf6 Completed 3 Cycles: *SUCCESS* at Tue Nov 12 15:48:56 CST 2024
Experiment C48_S2SW_b27c6cf6 Completed 2 Cycles: *SUCCESS* at Tue Nov 12 16:07:04 CST 2024
Experiment C48_S2SWA_gefs_b27c6cf6 Completed 1 Cycles: *SUCCESS* at Tue Nov 12 16:44:28 CST 2024
Experiment C96C48_hybatmDA_b27c6cf6 Completed 3 Cycles: *SUCCESS* at Tue Nov 12 17:01:51 CST 2024

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI/CD Issue related to CI/CD label Nov 13, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 14, 2024
@emcbot emcbot added the CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera label Nov 14, 2024
@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 14, 2024
@emcbot
Copy link

emcbot commented Nov 14, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3090


Experiment C96_S2SWA_gefs_replay_ics_016e98ed Completed 1 Cycles: *SUCCESS* at Thu Nov 14 10:13:28 UTC 2024
Experiment C48_ATM_016e98ed Completed 2 Cycles: *SUCCESS* at Thu Nov 14 10:25:37 UTC 2024
Experiment C48mx500_3DVarAOWCDA_016e98ed Completed 2 Cycles: *SUCCESS* at Thu Nov 14 10:31:47 UTC 2024
Experiment C48_S2SWA_gefs_016e98ed Completed 1 Cycles: *SUCCESS* at Thu Nov 14 11:33:07 UTC 2024
Experiment C96C48_hybatmDA_016e98ed Completed 3 Cycles: *SUCCESS* at Thu Nov 14 11:51:05 UTC 2024
Experiment C96_atm3DVar_016e98ed Completed 3 Cycles: *SUCCESS* at Thu Nov 14 11:56:55 UTC 2024
Experiment C96C48_hybatmaerosnowDA_016e98ed Completed 3 Cycles: *SUCCESS* at Thu Nov 14 11:57:09 UTC 2024
Experiment C48_S2SW_016e98ed Completed 2 Cycles: *SUCCESS* at Thu Nov 14 12:15:04 UTC 2024
Experiment C96C48_ufs_hybatmDA_016e98ed Completed 3 Cycles: *SUCCESS* at Thu Nov 14 12:21:30 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 6bde6ac into NOAA-EMC:develop Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees

@mingshichen-noaa mingshichen-noaa

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mingshichen-noaa @WalterKolczynski-NOAA @emcbot @KateFriedman-NOAA @DavidHuber-NOAA @TerrenceMcGuinness-NOAA