Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move mask from input buffer object to field object #1411

Merged
merged 6 commits into from
Nov 20, 2023
Merged

move mask from input buffer object to field object #1411

merged 6 commits into from
Nov 20, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Nov 15, 2023 •
edited
Loading

Description
This moves the mask that was previously only stored in the input array to the field object so it can be used for later reductions.

How Has This Been Tested?
amd box with latest intel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 requested a review from uramirez8707 November 15, 2023 23:12
uramirez8707
uramirez8707 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. It looks good to me.

@thomas-robinson thomas-robinson merged commit df5d291 into NOAA-GFDL:dmUpdate Nov 20, 2023
17 of 18 checks passed
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
move mask from input buffer object to field object (NOAA-GFDL#1411)
9c8bb28 
* fix diag_send_complete loops and add get_file_ids

* initial changes to move mask

---------

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
feat: modern diag move mask from input buffer object to field object (N…
82cc1bd 
…OAA-GFDL#1411)
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
move mask from input buffer object to field object (NOAA-GFDL#1411)
f8c54d4 
* fix diag_send_complete loops and add get_file_ids

* initial changes to move mask

---------

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
fix: move mask from input buffer object to field object (NOAA-GFDL#1411)
584dd56
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
fix: move mask from input buffer object to field object (NOAA-GFDL#1411)
b2f51e6
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
fix: move mask from input buffer object to field object (NOAA-GFDL#1411)
18ccd7b
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
@rem1776
fix: move mask from input buffer object to field object (NOAA-GFDL#1411)
cb5f8ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uramirez8707 uramirez8707 uramirez8707 approved these changes

@thomas-robinson thomas-robinson thomas-robinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rem1776 @thomas-robinson @uramirez8707