revert argument changes for xgrid

[rem1776]

Description
The data argument was changed as part of #1355, but this broke some of the coupler code (and likely other components). This reverts the xgrid changes to arguments.

How Has This Been Tested?
make check on amd, ci

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• make distcheck passes

[thomas-robinson]

Let's keep this open while we assess how much work it will be to update coupler and the components. I would rather have good code with good coding practice than revert back to the old coding standards.

[bensonr]

Was there an issue with testing requiring these to be reverted? I can see us having to do it for optionals, but why would it affect required arguments?

[rem1776]

Was there an issue with testing requiring these to be reverted? I can see us having to do it for optionals, but why would it affect required arguments?

You can specify the argument name for required arguments as well, its just not as common, so it ends up being the same issue as the optional arguments.

[bensonr]

@rem1776 - much of this could become obsolete if the stock integration/calculations are removed as part of the coupler refactor project. I'll be taking some of that discussion to the appropriate body within GFDL.

[rem1776]

@rem1776 - much of this could become obsolete if the stock integration/calculations are removed as part of the coupler refactor project. I'll be taking some of that discussion to the appropriate body within GFDL.

We made the change in the coupler to fix this so I'll close this one. I think that works out better cause then these calls can just be removed as part of the refactor project.