Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dm update main #1422

Merged
merged 29 commits into from
Nov 30, 2023
Merged

Dm update main #1422

merged 29 commits into from
Nov 30, 2023

Conversation

uramirez8707
Copy link
Contributor

Description
Bring in the updates from main + solve some minor merge conflicts

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

laurenchilutti and others added 29 commits August 16, 2023 14:58
@laurenchilutti
fix: unallocated variable access in test_mpp_nesting (NOAA-GFDL#1336)
5326fd9
@rem1776
fix: mpp_clock test failures (NOAA-GFDL#1338)
e154315
@laurenchilutti
fix: replacing cray pointers with fortran pointers in mpp_scatter and…
8d75797 
… gather (NOAA-GFDL#1312)
@mcallic2
chore!: adds ifdef use_drifters in all drifter modules (NOAA-GFDL#1329)
0fb9bd0 
BREAKING CHANGE: Deprecates the modules in the `drifters` subdirectory. If using the modules, you must compile FMS with the `-Duse_drifters` CPP flag.
@bensonr
fix: cleanup of mpp::get_peset function (NOAA-GFDL#1275)
a46bd94
@rem1776
ci: add io flag to intel test(NOAA-GFDL#1282)
d520e5a
@rem1776
fix: remove isspace function call for parser(NOAA-GFDL#1349)
3ffc427
@mlee03
fix: deallocate arrays in interpolator_end (NOAA-GFDL#1297)
dd53551
@mlee03
feat: add assignment override in fms2_io for interpolator_type_eq (NO…
4b9e0e8 
…AA-GFDL#1287)
@rem1776
Revert: "feat: add assignment override in fms2_io for interpolator_ty…
61cc3b9 
…pe_eq (NOAA-GFDL#1287)" (NOAA-GFDL#1360)

This reverts commit 4b9e0e8.
@rem1776 @mlee03
@mcallic2 @J-Lentz
feat: expand mixed precision support to most modules (NOAA-GFDL#1366)
b25a7c5 
BREAKING CHANGE: In coupler_types.F90,  `coupler_nd_field_type` and `coupler_nd_values_type` have been renamed to indicate real kind value: `coupler_nd_real4/8_field_type` and `coupler_nd_real4/8_values_type`. The `bc` field within `coupler_nd_bc_type` was modified to use r8_kind within the value and field types, and an additional field added `bc_r4` to use r4_kind values.

Includes:

* feat: eliminate use of real numbers for mixed precision in `block_control` (NOAA-GFDL#1195)

* feat: mixed precision field_manager  (NOAA-GFDL#1205)

* feat: mixed precision random_numbers_mod (NOAA-GFDL#1191)

* feat: mixed precision time_manager reals to r8 and clean up (NOAA-GFDL#1196)

* feat: mixed Precision tracer_manager  (NOAA-GFDL#1212)

* Mixed precision monin_obukhov (NOAA-GFDL#1116)

* Mixed precision: `monin_obukhov` unit tests (NOAA-GFDL#1272)

* mixed-precision diag_integral_mod  (NOAA-GFDL#1217)

* mixed precision time_interp (NOAA-GFDL#1252)

* mixed precision interpolator_mod  (NOAA-GFDL#1305)

* Mixed precision astronomy (NOAA-GFDL#1092)

* Mixed precision `data_override_mod` (NOAA-GFDL#1323)

* mixed precision exchange (NOAA-GFDL#1341)

* coupler mixed precision (NOAA-GFDL#1353)

* Mixed precision topography_mod (NOAA-GFDL#1250)

---------

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com>
Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
@rem1776
update for coupler ci for new image (NOAA-GFDL#1374)
f0ec93f
@mlee03
docs: CODE_STYLE update with mixed-precision related information (NOA…
5933858 
…A-GFDL#1373)
@uramirez8707
feat: add tile number to the filename for subregional files (NOAA-GFD…
85f409e 
…L#1376)
@rem1776 @mcallic2 @J-Lentz
feat: finish mixed mode support updates (NOAA-GFDL#1384)
11be274 
* mixed precision column_diagnostics  (NOAA-GFDL#1076)

* mixed precision mosaic2  (NOAA-GFDL#1074)

* mixed precision topography unit tests (NOAA-GFDL#1364)

* mixed precision tridiagonal (NOAA-GFDL#1363)

* mixed precision: add test for coupler_types and data_override changes (NOAA-GFDL#1361)

* Mixed precision `amip_interp_mod` (NOAA-GFDL#1365)

BREAKING CHANGE: Several variables and arrays which were previously public have been made private.
These variables and arrays are not used in ice_amip or ocean_amip.
amip_interp_type(r4_kind) and amip_interp_type(r8_kind) should be used for
r4_kind and r8_kind precision, respectively. amip_interp_type without a kind
parameter defaults to r8_kind.

Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com>
Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
@rem1776
fix: update macros and build options for mixed precision (NOAA-GFDL#1383
03ee7de 
)
@rem1776
fix: add allocatable and pure macros back into platform.h (NOAA-GFDL#…
06b94a7 
…1386)
@rem1776
chore: updates the various versions and changelog (NOAA-GFDL#1395)
527a42f
@github-actions
chore: add dev to version number (NOAA-GFDL#1400)
74338de
@rem1776
fix: allow for arguments within mpi launcher override (NOAA-GFDL#1401)
c70718d
@bcc2761
feat: data_override namelist flag to enable YAML data tables (NOAA-GF…
b0dbc30 
…DL#1382)
@mcallic2
chore: change variables named value to other variable names (NOAA-G…
302e3cb 
…FDL#1377)
@abrooks1085
chore: change variables named unit to 'iunit' (NOAA-GFDL#1394)
0ede185
@rem1776
fix: merge diag_manager start time fix from 2023.02.01 into main (NOA…
c92e40a 
…A-GFDL#1396)
@mcallic2
chore: changes variables named data to other variable names (NOAA-G…
be1856c 
…FDL#1355)
@rem1776
ci: cancel runs if newer commit available and update checkout action (N…
7898b51 
…OAA-GFDL#1416)
@rem1776
fix: libFMS module missing from installs (NOAA-GFDL#1414)
de220c1
@climbfuji
fix: append instead of replace extra flags for gnu 10+ with mpich (NO…
8287203 
…AA-GFDL#1418)
@uramirez8707
Merge branch 'main' of github.com:NOAA-GFDL/FMS into dmUpdate
ef2d5f8
@rem1776 rem1776 merged commit 8d6373d into NOAA-GFDL:dmUpdate Nov 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson thomas-robinson is a code owner

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@uramirez8707 @rem1776 @laurenchilutti @mcallic2 @bensonr @mlee03 @bcc2761 @abrooks1085 @climbfuji