Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional flag to time_interp_external to speedup initialization #1427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MJHarrison-GFDL
Copy link
Contributor

@MJHarrison-GFDL MJHarrison-GFDL commented Dec 15, 2023

Description

time_interp_external_nml:check_uniform_times=.true. will enable this option which performs a time axis check for uniformly spaced time levels prior to attempting to read the entire axis. In some cases, this will significantly reduce initialization time when reading large input files via data_override for example. It is possible that enabling this option
will result in answer changes in some configurations, so it is currently being set False by defauly.

Fixes # (issue)

How Has This Been Tested?

Using a stand-alone driver. Tested for single threading only.

Checklist:

  • My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] Any dependent changes have been merged and published in downstream modules
  • [ x] New check tests, if applicable, are included
  • make distcheck passes

 - time_interp_external_nml:check_uniform_times=.true. will enable
   this option which performs a time axis check for uniformly spaced
   time levels prior to attempting to read the entire axis. In some
   cases, this will significantly reduce initialization time when
   reading large input files via data_override for example.
@thomas-robinson
Copy link
Member

@MJHarrison-GFDL Thank you for the PR. Can you include a test that tests the functionality so we can include it in our test suite. Also, can you opne an issue describing the problem you are trying to solve.

@MJHarrison-GFDL
Copy link
Contributor Author

@thomas-robinson . The test I used is located on gaea : /lustre/f2/dev/Matthew.Harrison/tmp/FMS_fast_data_override/test . Initialization time went from 5min -> 2sec.

@thomas-robinson
Copy link
Member

@MJHarrison-GFDL that's great! Do you need help getting this test into the FMS test suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants