Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #259

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Documentation #259

merged 9 commits into from
Nov 12, 2024

Conversation

ceblanton
Copy link
Collaborator

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@ceblanton ceblanton changed the title Documentaiton Documentation Nov 7, 2024
@ilaflott
Copy link
Member

ilaflott commented Nov 8, 2024

the success/fail between the two checks is awkward... but i see some pull's happening in the history, so maybe one is being re-run when the other isn't or smth.

i don't see anything that explains the failure, having to do with the work here or otherwise... hopefully that succeeds on the next run.

@ceblanton
Copy link
Collaborator Author

ceblanton commented Nov 12, 2024

Even though I'm still working on these, I think we should merge them in. As we are all updating docs today, we'll see more merge conflicts unless we merge more frequently.

@ilaflott
Copy link
Member

Even though I'm still working on these, I think we should merge them in. As we are all updating docs today, we'll see more merge conflicts unless we merge more frequently.

still in draft mode! no one can merge it in, even with approval, if the PR is in draft mode.

@ilaflott ilaflott marked this pull request as ready for review November 12, 2024 19:47
Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the check passes, i approve.

@ceblanton ceblanton merged commit 7db1c19 into main Nov 12, 2024
2 checks passed
@ceblanton ceblanton deleted the docs branch November 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants