-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build script for intel oneapi and gcc compiler separately #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions:
- Do we want to continue to suport python 3.8?
- Should we allow the user to pass the desired name for the conda environment to be used, or do we want to keep it as
my_name
in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, let me test python 3.11.9, and update the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This requires a new GT4Py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small q about the python module import on C5, otherwise LGTM
module rm gcc | ||
module load gcc/12.2.0 | ||
module load boost/1.79.0 | ||
module load python/3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the python version here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, updated to the python 3.11.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending changes to examples/build_scripts/build_gaea_c5_gcc.sh
to update python version to 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the gt4py version is ok we're 👍
Description
add build env script for intel oneAPI build and gcc build of Pace with optimization options for loop unroll, and array prefetch.
please note that these options are needed to be incorported in the regression test and container build, with the purpose of supporting various supercomputers in the future.
Fixes # (issue)
If this is a hotfix to a released version, please specify it.
How Has This Been Tested?
The options for Intel compiler are tested using
Intel(R) oneAPI DPC++/C++ Compiler for applications running on Intel(R) 64, Version 2024.1.0 Build 20240308
and the gcc compiler was tesed using
gcc 13.2
Checklist: