Clean up of setup.py #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In setup.py, updating find_library to support windows ".dll" and check for special condition of using conda on macos, to then use ".so" library ext name string.
Functionalized all code for running ar, nm, ldd, and otool commands and checking for sp and openmp libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of testing done here to try to get successful builds on Windows. I think at this time, that is just not going to happen and probably will not happen until we migrate away from numpy distutils to meson. There is just too much interplay between setuptools, numpy, f2py, etc and Windows. The gfortran available from conda is outdated (version 5.3 from 2015).
But also done here was a reworking of setup.py to functionalize a lot of the logic for getting ip, sp (when needed), and openmp library information -- things that will make building on Windows easier down the road.