[init] 폰트, 색상 세팅 + 상단바 구현 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
May 15, 2024
build.gradle.kts
Outdated
app/src/main/res/values/strings.xml
Outdated
| @@ -1,3 +1,4 @@ | |||
| <resources> | |||
| <string name="app_name">KREAM-Android</string> | |||
| <string name="bar_search_label">"브랜드, 상품, 프로필, 태그 등"</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="bar_search_label">"브랜드, 상품, 프로필, 태그 등"</string> | |
| <!-- search_bar_hint --> | |
| <string name="search_bar_hint">"브랜드, 상품, 프로필, 태그 등"</string> |
이런 식으로 string을 작성할 때 위에 어떤 뷰에서 사용되는지를 주석을 달아주면 다른 사람들이 애가 어디서 사용되는지를 한 눈에 알아볼 수 있어서 편합니다
그리고 저는 보통 string 네이밍을 할 때 어떤 뷰에서 사용되는지_상세 설명 이런 식으로 작성하는 편인 것 같아요~
There was a problem hiding this comment.
네이밍 좋은데 피그마 네이밍을 따라주시면 조금 더 좋을 것 같습니다
피그마에서 공통 아이콘을 보면 탑바에 들어가는 아이콘들이 icn_bar 이런 식으로 묶여있고 해당 아이템이 icn_alarm 이렇게 네이밍 되어 있잖아요. 그러면 해당 아이콘 네이밍을 ic_bar_alarm_28 이런 식으로 가져가주면 좋을 것 같아요 ~
Comment on lines
37
to
40
| TextField(value = editText, | ||
| onValueChange = { editText = it }, | ||
| label = { Text(text = stringResource(id = R.string.bar_search_label)) } | ||
| ) |
There was a problem hiding this comment.
요거는 아까 말했던대로 커스텀 해야할 것 같아용 라벨에 힌트 넣어두면 글 작성해도 쟤가 안 사라지니까 ㅜ
| topBar = { | ||
| Column (modifier = Modifier.fillMaxWidth()){ | ||
| Row (modifier = Modifier.fillMaxWidth()){ | ||
| TextField(value = editText, |
jihyunniiii
approved these changes
May 16, 2024
app/build.gradle.kts
Outdated
Comment on lines
87
to
89
| ktlint { | ||
| disabledRules = listOf("standard:function-naming") | ||
| } |
| import org.sopt.kream.theme.head1Bold | ||
|
|
||
| val pages = listOf("추천", "랭킹", "발매정보", "럭셔리", "남성", "여성", "발견") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
폰트랑 색상 잘 적용되는거 같습니다~
상단 탭바 탭 패딩을 없애보려고 했는데 저자식 살이 안빠져요...