Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[init] 아이콘 세팅 #15

Merged
merged 7 commits into from
May 16, 2024
Merged

[init] 아이콘 세팅 #15

merged 7 commits into from
May 16, 2024

Conversation

t1nm1ksun
Copy link
Contributor

Related issue 🛠

Work Description ✏️

  • 피그마 아이콘들 svg로 저장 후 drawable 파일에 추가

Screenshot 📸

  • 없어용

Uncompleted Tasks 😅

  • 이것도 없어요

To Reviewers 📢

아이콘 컷!

Copy link
Contributor

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻👍🏻

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그룹화된 네이밍이 있으면 그거 앞에 추가한 다음에 상세 네이밍 진행시켜주세요 !
그리고 안드로이드 전용 ic 추가 안 되어있으니까 확인 부탁합니다 !!

Comment on lines 86 to 90
implementation("androidx.compose.ui:ui:1.6.7")
implementation("androidx.compose.material:material:1.6.7")
implementation("androidx.compose.ui:ui-tooling-preview:1.6.7")
androidTestImplementation("androidx.compose.ui:ui-test-junit4:1.6.7")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미 추가되어 있는 부분이라 지워주세요 ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_bar_alarm_28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_alarm_plus_24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_bar_back_24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_channel_ch_24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_bar_share_24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_etc_sort_16

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_etc_toggle_16

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_etc_toggle_circle_16

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ic_updown_up_8

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘네만 확인해보고 머지해용

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 다 __ 이렇게 되어있습니당
그리고 progerssbar -> bottom_navi 이걸루 바꿉시당

app/src/main/res/drawable/ic_saved_small_off_16.xml Outdated Show resolved Hide resolved
@t1nm1ksun t1nm1ksun merged commit 38a28ba into develop May 16, 2024
1 check passed
@t1nm1ksun t1nm1ksun deleted the init-icon-setting branch May 16, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[init] 아이콘 세팅
3 participants