[feat] TabLayout, EditText 생성 및 화면 이동 구현 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyobeen-Park
approved these changes
May 18, 2024
|
|
||
| private fun navigateToSearch() { | ||
| findNavController().navigate(R.id.action_home_to_search) | ||
| } |
There was a problem hiding this comment.
이거 한 번만 사용되는 것 같은데 그래도 함수화 하는게 좋을까요??? 저는 한 줄정도면 그냥 함수화 안하고 쓸 때도 많았거든요😅
There was a problem hiding this comment.
저는 가독성을 위해 최대한 함수화 해놓는 편입니다 !
There was a problem hiding this comment.
이 친구... 뭐하는 친구인가요..?????? ripple 없애는 역할인거 맞나요????
There was a problem hiding this comment.
컴포즈에서는 클릭할 때 기본적으로 ripple이 생기는데 해당 리플을 제거해주는 확장함수 입니다.
| @Composable | ||
| fun KreamTabBar( | ||
| indicatorColor: Color = Color.Black, | ||
| animationSpec: AnimationSpec<Dp> = tween(durationMillis = 250, easing = FastOutSlowInEasing), |
There was a problem hiding this comment.
이런것도 있었네요!! 애니메이션 쓴거 진짜 최고다😻
t1nm1ksun
approved these changes
May 18, 2024
| .wrapContentWidth(Alignment.CenterHorizontally), | ||
| color = White, | ||
| ) { | ||
| SubcomposeLayout( |
There was a problem hiding this comment.
이 레이아웃은 처음 보는데 SubComposeLayout은 무슨 장점이 있어 사용하신건가요?
There was a problem hiding this comment.
복잡한 레이아웃을 정의할 때 주로 사용한다고 하는데 ㅜ ㅈㅓ도 컴포즈는 아직 잘 몰라서리 ㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240518_093222.mp4
Uncompleted Tasks 😅
To Reviewers 📢