[init] ViewPager indicator 구현 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
approved these changes
May 19, 2024
There was a problem hiding this comment.
xml에서는 네이밍을 역순으로 하더라구요 (activity_main -> MainActivity)
indicator_tab_kream으로 네이밍하면 좋을 것 같네요 ~
t1nm1ksun
approved these changes
May 20, 2024
Comment on lines
7
to
15
| <com.google.android.material.tabs.TabLayout | ||
| android:id="@+id/tab_kream_indicator" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="2dp" | ||
| app:tabBackground="@color/gray04" | ||
| app:tabIndicator="@drawable/shape_tab_indicator_rect_2" | ||
| app:tabIndicatorAnimationMode="linear" | ||
| app:tabIndicatorColor="@color/black01" | ||
| app:tabIndicatorFullWidth="true" /> |
There was a problem hiding this comment.
화면 개수 많아지면 indicator 넓이가 짧아지나?
There was a problem hiding this comment.
예스예스!! tabLayout 길이가 고정되어 있어서 indicator는 총길이/화면 개수로 설정됩니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
2024-05-18.202529.mp4
Uncompleted Tasks 😅
To Reviewers 📢