[feat] 추천 뷰 구현 #24
Merged
[feat] 추천 뷰 구현 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/drawable/shape_border_radius_2.xml # app/src/main/res/values/strings.xml
jihyunniiii
reviewed
May 23, 2024
Comment on lines
+8
to
+9
| recommendForYouProducts = this.forYouList.map { it.toRecommendForYouProductModel() }, | ||
| recommendJustDroppedProducts = this.justDropList.map { it.toRecommendJustDroppedProductModel() }, |
There was a problem hiding this comment.
개인적으로는 it을 그대로 사용하는 것보다 네이밍을 해주고 사용하는 것을 선호하는 편이지만 갠취니까 그냥 참고만 해주세요 ~
| @@ -0,0 +1,8 @@ | |||
| package org.sopt.kream.domain.model | |||
|
|
|||
| import androidx.annotation.DrawableRes | |||
There was a problem hiding this comment.
Domain Layer는 순수 코틀린 파일만 있어야 합니다 (다른 라이브러리에 의존성 X) 이런 식으로 구현하면 androix 라이브러리에 의존성이 있는 상태가 되니 해당 파일은 presentation 으로 이동시키는 게 클린 아키텍처에 더 부합 할 것 같숩니당!
There was a problem hiding this comment.
헉 그렇군요..!! 감사합니다😻
There was a problem hiding this comment.
뷰홀더랑 네이밍 맞추는 편이 좋을 것 같습니다 ~
There was a problem hiding this comment.
헉 네이밍 바꾸면서 이걸 놓쳤네요😅 감사합니다!!
| holder: RecommendCircleMenuViewHolder, | ||
| position: Int, | ||
| ) { | ||
| holder.onBind(item.get(position).menu) |
There was a problem hiding this comment.
Suggested change
| holder.onBind(item.get(position).menu) | |
| holder.onBind(item[position].menu) |
그리고 이거 이미지 디쟌 측에서 추가해주시면 menu만 넘기는 게 아니라 그냥 아이템 객체 자체를 넘겨야 할 것 같숩니다
|
|
||
| <include | ||
| android:id="@+id/tab_kream_indicator" |
There was a problem hiding this comment.
Suggested change
| android:id="@+id/tab_kream_indicator" | |
| android:id="@+id/include_recommend_kream_indicator" |
| private val binding: ItemRecommendJustDroppedProductBinding, | ||
| private val navigateToProductDetail: (Int) -> Unit, | ||
| ) : RecyclerView.ViewHolder(binding.root) { | ||
| private var recommendJustDroppedAdapter: RecommendJustDroppedAdapter = RecommendJustDroppedAdapter(navigateToProductDetail) |
Comment on lines
22
to
41
| InstagramModel( | ||
| image = R.drawable.img_recommend_style_01, | ||
| id = "@zzz.myam", | ||
| ), | ||
| InstagramModel( | ||
| image = R.drawable.img_recommend_style_01, | ||
| id = "@zzz.myam", | ||
| ), | ||
| InstagramModel( | ||
| image = R.drawable.img_recommend_style_01, | ||
| id = "@zzz.myam", | ||
| ), | ||
| InstagramModel( | ||
| image = R.drawable.img_recommend_style_01, | ||
| id = "@zzz.myam", | ||
| ), | ||
| InstagramModel( | ||
| image = R.drawable.img_recommend_style_01, | ||
| id = "@zzz.myam", | ||
| ), |
There was a problem hiding this comment.
요거 디자인 측이 만들어둔대로 설정 부탁해요
There was a problem hiding this comment.
얘네는 스트링 추출해 주셔도 좋을 것 같네요
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:id="@+id/cl_recommend_for_you_more" | ||
| android:layout_width="0dp" | ||
| android:layout_height="44dp" |
Comment on lines
20
to
23
| android:id="@+id/iv_recommend_for_you_more" | ||
| android:layout_width="30dp" | ||
| android:layout_height="0dp" | ||
| android:layout_marginStart="7dp" |
# Conflicts: # app/src/main/java/org/sopt/kream/data/datasource/ProductRemoteDataSource.kt # app/src/main/java/org/sopt/kream/data/datasourceimpl/ProductRemoteDataSourceImpl.kt # app/src/main/java/org/sopt/kream/data/repository/ProductRepositoryImpl.kt # app/src/main/java/org/sopt/kream/data/service/ProductService.kt # app/src/main/java/org/sopt/kream/domain/repository/ProductRepository.kt # app/src/main/java/org/sopt/kream/presentation/common/ViewModelFactory.kt # app/src/main/res/drawable/shape_border_radius_8.xml # app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_Recording_20240523_175556_KREAM-Android.mp4
Uncompleted Tasks 😅
To Reviewers 📢