[feat] 상품 상세 뷰 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/sopt/kream/data/service/ProductService.kt
Hyobeen-Park
approved these changes
May 23, 2024
|
|
||
| companion object { | ||
| const val MEMBER_ID = 1 | ||
| } |
There was a problem hiding this comment.
오 여기다가 상수로 선언해주니까 좋네요!!
There was a problem hiding this comment.
크크 상수화 잘 하면 가독성이 더 높아지는 것 같숨니다
| tvProductDetailInfoAdditionalContent.text = productDetailInfoModel.additionalContent | ||
| ivProductDetailInfoAdditionalContent.visibility = if (productDetailInfoModel.additionalContent.isNullOrEmpty()) View.INVISIBLE else View.VISIBLE | ||
| (viewProductDetailInfo.layoutParams as? ViewGroup.MarginLayoutParams)?.run { | ||
| marginStart = productDetailInfoModel.productDetailInfoType.margin.toPx() |
There was a problem hiding this comment.
오!! 여기서 마진 설정한거 맞나요??? 우왕 저 저번에 실패했던건데...!! 오오오오
There was a problem hiding this comment.
맞숩니당 ~ 아이템마다 마진 값이 달라서 여기서 설정해 주었어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240523_171142.mp4
Uncompleted Tasks 😅
To Reviewers 📢