Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 스크랩 해제 API 연동 #31

Merged
merged 5 commits into from
May 23, 2024

Conversation

t1nm1ksun
Copy link
Contributor

Related issue 🛠

Work Description ✏️

  • 스크랩 해제 API 연동

Screenshot 📸

image

Uncompleted Tasks 😅

없음당

To Reviewers 📢

코드가 지저분하고 필요없는게 들어가있을 수도 있지만...
추후에 리팩하겠습니다 저희 시간이 없으니...

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했더요 ~

@Header("memberId") memberId: Int,
): BaseResponse<ResponseReleaseProductDto>

@HTTP(method = "DELETE", path = "scrap", hasBody = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@HTTP(method = "DELETE", path = "scrap", hasBody = true)
@DELETE("scrap")

이렇게 해줘도 되지 않나요?

Copy link
Contributor

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왕 수고하셨습니다~~!!! 마지막까지 파이팅😊

@t1nm1ksun t1nm1ksun merged commit 105eaaf into develop May 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 스크랩 해제 API 연동
3 participants