Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brakedown #37

Closed
wants to merge 248 commits into from
Closed

Brakedown #37

wants to merge 248 commits into from

Conversation

autquis
Copy link
Collaborator

@autquis autquis commented Oct 25, 2023

Here it is, Brakedown!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

mmagician and others added 30 commits June 27, 2023 12:07
@mmagician
Stub out the PolynomialCommitment trait for Ligero
a4c6e2b
@Antonio95
implementing matrix functionality, not tested
8f6becd
@Antonio95
further matrix functionality, commit function started
aa94494
@Antonio95
testing commit signing
d0f00b1
@Antonio95
first part of commit function compiling
848933b
@Antonio95
requested PR changes implemented
543c8e1
@Antonio95
added to_field function one-liner and tests for all existing matrix f…
a39289d 
…unctions
@Antonio95
changed matrix-related functions from F:PrimeField to F:Field
d82c4e3
@mmagician
Add params and generics to the Ligero constructor
c20d28d
@mmagician
Create a custom and default constructors for Ligero PCS struct
008151b
@mmagician
Merge pull request #2 from mmagician/pcs-constructor
ffea25d 
PCS Ligero constructor
@Antonio95
in the middle of commit function, not compiling
91184aa
@Antonio95
merged with ligero (constructor added)
2941c8a
@Antonio95
added reed-solomon encoding and a test for the fft interface
4ef9adb
@Antonio95
continued commit method, left placeholders for Merkle-tree parts; NOT…
b008983 
… compiling
@Antonio95
changed reed-solomon code to receive fft_domain from caller; continue…
c13cf28 
…d work on commit function
@mmagician
make a Commitment struct with MT root & transcipt
dd7e28f
@mmagician
stub out the Commitment verify method (well-formedness check)
bb3b6bb
@mmagician
Ligero with a sponge for Fiat-Shamir Commitment well-formed check
1d6c30b
@mmagician
use jf_primitives for IOPTranscript for FS transform
129cbfb
@Antonio95
deleted settings.json file
7183c1e
@mmagician
Merge pull request #1 from Antonio95/commit
903eaaf 
Commit
@mmagician
Merge branch 'ligero' into commitment-with-transcript
5d349b6
@mmagician
Merge pull request #4 from mmagician/commitment-with-transcript
edae282 
Commitment with transcript
@mmagician
remove merge artifacts
fe63bc2
@mmagician
Fix getting the indices from the transcript
d58c366
@mmagician
path verification with the random index retrieved from the transcript
aa913ef
@mmagician
verify the random linear combinations in the F-S commitment check
243be3d
@mmagician
hashing columns - WIP
4c7631d
@Antonio95
well_formedness_check completed, not tested
348c88e
mmagician and others added 29 commits October 19, 2023 15:31
@mmagician
Merge branch 'master' into breakdown
1d34607
@mmagician
move tensor_inner to utils.rs; rename to tensor_vec
09daffd
@mmagician
Add Brakedown benches
3952d3f
@mmagician
better memory handling in Brakedown encode fn
f7d5e10
@Antonio95
Merge pull request #11 from HungryCatsStudio/brakedown-opt
662bea1 
Minor optimizations to Brakedown impl
@Antonio95
Update benches/benches.rs
dd4024e
@Antonio95
Update src/linear_codes/ligero.rs
c01b3c2
@Antonio95
Update src/linear_codes/mod.rs
bd7c1d5
@Antonio95
Update src/linear_codes/multilinear_brakedown/tests.rs
6d5712b
@Antonio95
resolved merge conflict with master
fac3d00
@Antonio95
Merge pull request #10 from HungryCatsStudio/breakdown
b601408 
Brakedown
@Antonio95
switched to proof/commitment size computation using serialisation - m…
47c8c83 
…uch better
@Antonio95
removed old method, reorganised displayed information
0a9664d
@Antonio95
cleaned code
4e28828
@Antonio95
Merge branch 'master' into benching-size
18e036c
@Antonio95
added brakedown benchmarks
35a515e
@Antonio95
formatted, uncommented, cleaned
48a0640
@Antonio95
switched back to pub(crate) at a few places where it's no longer need…
7ee02ae 
…ed thanks to serialisation
@Antonio95
removed newly added doc comment - unnecesary
85f2ab2
@mmagician
Merge pull request #12 from HungryCatsStudio/benching-size
b22565f 
Benching size
@Antonio95
tweaked distance formula
5814d48
@Antonio95
Merge pull request #13 from HungryCatsStudio/fair-comparison
5b3523d 
tweaked distance formula
@mmagician @Antonio95 @autquis
Improve docs and naming for lin code trait (#35)
51447c6 
* Improve docs and naming for lin code trait

* Rename `LinCodeInfo` -> `LinCodeParametersInfo` and update its doc

* wrap a long comment

* Apply suggestions from code review

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>

* Move implementation description of `tensor` into implementers, not trait

* fmt

* remove old todos

* explicit description of `tensor` following Thaler 10.5.1

* Minor comment fixes

* place util hashers under cfg flags

* More inline and doc comment fixes

* remove trailing character

* Add docs for `data_structure.rs`

* Fix typo

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>

* Fix the docs for `SprsMat`

* Remove the univariate definition from tensoring docs

---------

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
Co-authored-by: Hossein Moghaddas <autquis@gmail.com>
@autquis
Make matrix generation more efficient
9a80af1
@autquis
Finalize Brakedown
8214fa0
@autquis
Remove bench files
0364ad3
@autquis
Remove Hyrax
dfb64ff
@autquis
Clean more
2a9391f
@autquis
Bring src/README.md back
647ab3b
@autquis autquis closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autquis @mmagician @Antonio95