Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GNPSDownloader class to support gnps2 #294

Merged
merged 10 commits into from
Jan 20, 2025
Merged

update GNPSDownloader class to support gnps2 #294

merged 10 commits into from
Jan 20, 2025
+111 −60

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jan 10, 2025 •
edited
Loading

Updated GNPSDownloader class to support gnps2 data.

This was referenced Jan 10, 2025
Merged
Merged
Merged
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng mentioned this pull request Jan 10, 2025
Merged
@CunliangGeng CunliangGeng force-pushed the update_gnpsformat_from_archive branch from a2aae02 to d541034 Compare January 10, 2025 15:34
@CunliangGeng CunliangGeng force-pushed the update_GNPSDownloader_for_gnps2 branch from dead658 to 408fdbf Compare January 10, 2025 15:34
@CunliangGeng CunliangGeng self-assigned this Jan 10, 2025
@CunliangGeng CunliangGeng requested a review from gcroci2 January 10, 2025 15:47
@CunliangGeng CunliangGeng marked this pull request as ready for review January 10, 2025 15:47
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 20, 2025 •
edited
Loading

Merge activity

  • Jan 20, 10:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 10:52 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 20, 10:53 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng changed the base branch from update_gnpsformat_from_archive to graphite-base/294 January 20, 2025 15:47
@CunliangGeng CunliangGeng changed the base branch from graphite-base/294 to dev January 20, 2025 15:50
@CunliangGeng CunliangGeng force-pushed the update_GNPSDownloader_for_gnps2 branch from 408fdbf to cdaf38c Compare January 20, 2025 15:52
@CunliangGeng CunliangGeng merged commit 9839a82 into dev Jan 20, 2025
2 of 3 checks passed
@CunliangGeng CunliangGeng deleted the update_GNPSDownloader_for_gnps2 branch January 20, 2025 15:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2