Update GNPSFileMappingLoader to support GNPS2 data #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function is only used by GNPSFileMappingLoader, so it's moved as a private method of GNPSFileMappingLoader now. It's further updated to support the gnps2 workflows.
This was referenced Jan 20, 2025
Merged
|
gcroci2
approved these changes
Jan 21, 2025
|
The static typing check is failing @CunliangGeng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the commit messages for the detail of changes.
Please ignore errors of static typing check, which will be fixed in a new PR.