Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move config template file outside of code folder #303

Merged
merged 1 commit into from
Jan 22, 2025
Merged

move config template file outside of code folder #303

merged 1 commit into from
Jan 22, 2025

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jan 22, 2025 •
edited
Loading

The config template file nplinker.toml is not required by the code because users will provide it. So moving this file outside of the src folder to a new folder config.

@CunliangGeng CunliangGeng mentioned this pull request Jan 22, 2025
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng requested a review from gcroci2 January 22, 2025 15:52
@CunliangGeng CunliangGeng self-assigned this Jan 22, 2025
@CunliangGeng CunliangGeng marked this pull request as ready for review January 22, 2025 15:52
@CunliangGeng CunliangGeng force-pushed the move_config_file branch 2 times, most recently from 0e075d6 to d80cc41 Compare January 22, 2025 16:33
@CunliangGeng CunliangGeng changed the base branch from remove_unused_or_deprecated_code_and_data to graphite-base/303 January 22, 2025 16:41
@CunliangGeng CunliangGeng changed the base branch from graphite-base/303 to dev January 22, 2025 16:43
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 22, 2025 •
edited
Loading

Merge activity

  • Jan 22, 11:43 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 11:44 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng merged commit 369f198 into dev Jan 22, 2025
1 of 2 checks passed
@CunliangGeng CunliangGeng deleted the move_config_file branch January 22, 2025 16:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2