Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for changes in NQCBase#11 #351

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

Alexsp32
Copy link
Member

Removed ASEConvert.jl example since it includes unnecessary extra steps since James implemented the ase conversion functions.
Replaced with an example for how to use PythonCall.jl to create an ase atoms object and how to convert it instead.

@Alexsp32
Copy link
Member Author

CI will fail due to PR dependency and pulling NQCBase from Registry, but works when build locally.

@Alexsp32 Alexsp32 marked this pull request as ready for review July 31, 2024 09:43
@Alexsp32
Copy link
Member Author

Documentation now builds properly: Preview @reinimaurer1 do you have a moment to review?

@Alexsp32 Alexsp32 requested a review from Snowd1n August 16, 2024 10:28
Copy link

@Snowd1n Snowd1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks like incredible work. 10/10 👌

@Snowd1n Snowd1n merged commit d853f7f into main Aug 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants